aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2023-02-07 08:51:07 +0100
committerMarkus Armbruster <armbru@redhat.com>2023-02-23 14:10:17 +0100
commita0d0267779850f0dee70656dd7c0d11a458bfbaa (patch)
treecff722c8bee55bb86dd8cf2a11be1688e8207b27
parentf1a4697c236aae8f7d13042e4c6a31c228aa8595 (diff)
downloadqemu-a0d0267779850f0dee70656dd7c0d11a458bfbaa.zip
qemu-a0d0267779850f0dee70656dd7c0d11a458bfbaa.tar.gz
qemu-a0d0267779850f0dee70656dd7c0d11a458bfbaa.tar.bz2
hw/core: Improve error message when machine doesn't provide NMIs
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague error message (qemu) nmi Error: this feature or command is not currently supported to Error: machine does not provide NMIs Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20230207075115.1525-5-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Juan Quintela <quintela@redhat.com>
-rw-r--r--hw/core/nmi.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/core/nmi.c b/hw/core/nmi.c
index 481c4b3..a7bce8a 100644
--- a/hw/core/nmi.c
+++ b/hw/core/nmi.c
@@ -22,7 +22,6 @@
#include "qemu/osdep.h"
#include "hw/nmi.h"
#include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
#include "qemu/module.h"
#include "monitor/monitor.h"
@@ -70,7 +69,7 @@ void nmi_monitor_handle(int cpu_index, Error **errp)
if (ns.handled) {
error_propagate(errp, ns.err);
} else {
- error_setg(errp, QERR_UNSUPPORTED);
+ error_setg(errp, "machine does not provide NMIs");
}
}