aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2023-03-09 14:08:54 -0500
committerKevin Wolf <kwolf@redhat.com>2023-04-25 13:17:28 +0200
commit6bb685531aaeaf8a5bc4628856d66345b4cf7425 (patch)
treec8edb55d20f4295976c7afa7e581cb31e812ae4f
parent263d5e12c30fa0e6916494ea5f7afc2ab129c06f (diff)
downloadqemu-6bb685531aaeaf8a5bc4628856d66345b4cf7425.zip
qemu-6bb685531aaeaf8a5bc4628856d66345b4cf7425.tar.gz
qemu-6bb685531aaeaf8a5bc4628856d66345b4cf7425.tar.bz2
hmp: convert handle_hmp_command() to AIO_WAIT_WHILE_UNLOCKED()
The HMP monitor runs in the main loop thread. Calling AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread is equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ...) because neither unlocks the AioContext and the latter's assertion that we're in the main loop succeeds. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20230309190855.414275-6-stefanha@redhat.com> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r--monitor/hmp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/monitor/hmp.c b/monitor/hmp.c
index fee4103..5cab56d 100644
--- a/monitor/hmp.c
+++ b/monitor/hmp.c
@@ -1167,7 +1167,7 @@ void handle_hmp_command(MonitorHMP *mon, const char *cmdline)
Coroutine *co = qemu_coroutine_create(handle_hmp_command_co, &data);
monitor_set_cur(co, &mon->common);
aio_co_enter(qemu_get_aio_context(), co);
- AIO_WAIT_WHILE(qemu_get_aio_context(), !data.done);
+ AIO_WAIT_WHILE_UNLOCKED(NULL, !data.done);
}
qobject_unref(qdict);