diff options
author | Kevin Wolf <kwolf@redhat.com> | 2019-02-18 14:09:32 +0100 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2019-02-25 15:03:19 +0100 |
commit | 6886ceaf61c2399419258246a064485e9b1e51ac (patch) | |
tree | 81609e35fb15b3b34e4edd2aef68e243ff32ca70 | |
parent | 5ad81b4946baf948c65cf7e1436d9b74803c1280 (diff) | |
download | qemu-6886ceaf61c2399419258246a064485e9b1e51ac.zip qemu-6886ceaf61c2399419258246a064485e9b1e51ac.tar.gz qemu-6886ceaf61c2399419258246a064485e9b1e51ac.tar.bz2 |
io: Make qio_channel_yield() interruptible
Similar to how qemu_co_sleep_ns() allows preemption from an external
coroutine entry, allow reentering qio_channel_yield() early.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r-- | include/io/channel.h | 9 | ||||
-rw-r--r-- | io/channel.c | 10 |
2 files changed, 16 insertions, 3 deletions
diff --git a/include/io/channel.h b/include/io/channel.h index da2f138..59460cb 100644 --- a/include/io/channel.h +++ b/include/io/channel.h @@ -739,10 +739,13 @@ void qio_channel_detach_aio_context(QIOChannel *ioc); * addition, no two coroutine can be waiting on the same condition * and channel at the same time. * - * This must only be called from coroutine context + * This must only be called from coroutine context. It is safe to + * reenter the coroutine externally while it is waiting; in this + * case the function will return even if @condition is not yet + * available. */ -void qio_channel_yield(QIOChannel *ioc, - GIOCondition condition); +void coroutine_fn qio_channel_yield(QIOChannel *ioc, + GIOCondition condition); /** * qio_channel_wait: diff --git a/io/channel.c b/io/channel.c index 8dd0684..303376e 100644 --- a/io/channel.c +++ b/io/channel.c @@ -469,6 +469,16 @@ void coroutine_fn qio_channel_yield(QIOChannel *ioc, } qio_channel_set_aio_fd_handlers(ioc); qemu_coroutine_yield(); + + /* Allow interrupting the operation by reentering the coroutine other than + * through the aio_fd_handlers. */ + if (condition == G_IO_IN && ioc->read_coroutine) { + ioc->read_coroutine = NULL; + qio_channel_set_aio_fd_handlers(ioc); + } else if (condition == G_IO_OUT && ioc->write_coroutine) { + ioc->write_coroutine = NULL; + qio_channel_set_aio_fd_handlers(ioc); + } } |