diff options
| author | Li Qiang <liq3ea@163.com> | 2021-05-15 20:04:01 -0700 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2021-05-27 11:55:59 +0200 |
| commit | 63736af5a6571d9def93769431e0d7e38c6677bf (patch) | |
| tree | ddafc598da6ec506818a2c145e8bccd9a91563a8 | |
| parent | f6091d86ba9ea05f4e111b9b42ee0005c37a6779 (diff) | |
| download | qemu-63736af5a6571d9def93769431e0d7e38c6677bf.zip qemu-63736af5a6571d9def93769431e0d7e38c6677bf.tar.gz qemu-63736af5a6571d9def93769431e0d7e38c6677bf.tar.bz2 | |
vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing' (CVE-2021-3544)
If 'virgl_renderer_resource_attach_iov' failed, the 'res_iovs' will
be leaked.
Fixes: CVE-2021-3544
Reported-by: Li Qiang <liq3ea@163.com>
virtio-gpu fix: 33243031da ("virtio-gpu-3d: fix memory leak
in resource attach backing")
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210516030403.107723-7-liq3ea@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | contrib/vhost-user-gpu/virgl.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c index c669d73..a16a311 100644 --- a/contrib/vhost-user-gpu/virgl.c +++ b/contrib/vhost-user-gpu/virgl.c @@ -287,8 +287,11 @@ virgl_resource_attach_backing(VuGpu *g, return; } - virgl_renderer_resource_attach_iov(att_rb.resource_id, + ret = virgl_renderer_resource_attach_iov(att_rb.resource_id, res_iovs, att_rb.nr_entries); + if (ret != 0) { + g_free(res_iovs); + } } static void |