diff options
| author | Stefan Weil <sw@weilnetz.de> | 2015-03-14 17:00:44 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2015-03-27 10:01:12 +0000 |
| commit | 2115f2a1d8c77c2a735add1ed02ae0c1feae0d9a (patch) | |
| tree | 2949823072ed214228034c99c6d3af485a8273a9 | |
| parent | 4ad9e2b36e1e00fe5b96c3448ecd673e11c4d6d8 (diff) | |
| download | qemu-2115f2a1d8c77c2a735add1ed02ae0c1feae0d9a.zip qemu-2115f2a1d8c77c2a735add1ed02ae0c1feae0d9a.tar.gz qemu-2115f2a1d8c77c2a735add1ed02ae0c1feae0d9a.tar.bz2 | |
nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
The shift operation on nlb gives a 32 bit result if no type cast is
applied. This bug was reported by Coverity.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-id: 1426348844-8793-1-git-send-email-sw@weilnetz.de
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | hw/block/nvme.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 0f3dfb9..1e07166 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -222,7 +222,7 @@ static uint16_t nvme_rw(NvmeCtrl *n, NvmeNamespace *ns, NvmeCmd *cmd, uint8_t lba_index = NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas); uint8_t data_shift = ns->id_ns.lbaf[lba_index].ds; - uint64_t data_size = nlb << data_shift; + uint64_t data_size = (uint64_t)nlb << data_shift; uint64_t aio_slba = slba << (data_shift - BDRV_SECTOR_BITS); int is_write = rw->opcode == NVME_CMD_WRITE ? 1 : 0; |