diff options
| author | Greg Kurz <groug@kaod.org> | 2018-02-01 20:47:41 +0100 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2018-02-12 19:39:27 -0600 |
| commit | 00e9fba2beb4a0366965ce4ec1068df68ce9f4c0 (patch) | |
| tree | 3f2cfd0e0f60f1c16acd1a1e3a55eb5b3cc3e778 | |
| parent | 63112b16a6abd31d40df2b9a1dd713b42eb59c6b (diff) | |
| download | qemu-00e9fba2beb4a0366965ce4ec1068df68ce9f4c0.zip qemu-00e9fba2beb4a0366965ce4ec1068df68ce9f4c0.tar.gz qemu-00e9fba2beb4a0366965ce4ec1068df68ce9f4c0.tar.bz2 | |
spapr: add missing break in h_get_cpu_characteristics()
Detected by Coverity (CID 1385702). This fixes the recently added hypercall
to let guests properly apply Spectre and Meltdown workarounds.
Fixes: c59704b25473 "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS"
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
(cherry picked from commit fa86f59234919b479b7e8da6b0dc2dad894a5eac)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
| -rw-r--r-- | hw/ppc/spapr_hcall.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 0e1a0ae..8416452 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -1698,6 +1698,7 @@ static target_ulong h_get_cpu_characteristics(PowerPCCPU *cpu, switch (safe_indirect_branch) { case SPAPR_CAP_FIXED: characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED; + break; default: /* broken */ assert(safe_indirect_branch == SPAPR_CAP_BROKEN); break; |