diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-06-05 19:56:52 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-06-10 12:59:09 +0200 |
| commit | c7785e243195799749242b5fc741b8fbf1053f82 (patch) | |
| tree | 12bf3f64404a801b3276a41c9dcd32d4e25baa44 | |
| parent | 59a4757bb4d01c9dfb50e872a9d04ad1f1c38049 (diff) | |
| download | qemu-c7785e243195799749242b5fc741b8fbf1053f82.zip qemu-c7785e243195799749242b5fc741b8fbf1053f82.tar.gz qemu-c7785e243195799749242b5fc741b8fbf1053f82.tar.bz2 | |
hw/gpio/pca9552: Avoid using g_newa()
We have pin_count <= PCA955X_PIN_COUNT_MAX. Having
PCA955X_PIN_COUNT_MAX = 16, it is safe to explicitly
allocate the char buffer on the stack, without g_newa().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Glenn Miles <milesg@linux.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20250605193540.59874-2-philmd@linaro.org>
| -rw-r--r-- | hw/gpio/pca9552.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c index d65c0a2..1e10238 100644 --- a/hw/gpio/pca9552.c +++ b/hw/gpio/pca9552.c @@ -76,7 +76,7 @@ static void pca955x_display_pins_status(PCA955xState *s, return; } if (trace_event_get_state_backends(TRACE_PCA955X_GPIO_STATUS)) { - char *buf = g_newa(char, k->pin_count + 1); + char buf[PCA955X_PIN_COUNT_MAX + 1]; for (i = 0; i < k->pin_count; i++) { if (extract32(pins_status, i, 1)) { |