diff options
author | Kevin Wolf <kwolf@redhat.com> | 2025-07-14 15:01:53 +0200 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2025-07-14 15:42:15 +0200 |
commit | 975d9ff32e37f67e82d0da546cfb567bdee9c6fb (patch) | |
tree | 88af138695a941ab8738053ee867265131b82343 | |
parent | 60f609c1526102df35d8de8f513a80e6d3528bd8 (diff) | |
download | qemu-975d9ff32e37f67e82d0da546cfb567bdee9c6fb.zip qemu-975d9ff32e37f67e82d0da546cfb567bdee9c6fb.tar.gz qemu-975d9ff32e37f67e82d0da546cfb567bdee9c6fb.tar.bz2 |
block: Allow bdrv_new() with and without graph lock
bdrv_new() calls bdrv_drained_begin(), which can poll and therefore
can't be called while holding the graph lock. One option to make sure
that this call is allowed would be marking bdrv_new() GRAPH_UNLOCKED.
However, this is actually an unnecessary restriction because we know
that we only just created the BlockDriverState and it isn't even part of
the graph yet. We can use bdrv_do_drained_begin_quiesce() instead to
avoid the polling, which means that bdrv_new() can now safely be called
from callers that hold the graph lock as well as from callers that
don't.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r-- | block.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -431,7 +431,7 @@ BlockDriverState *bdrv_new(void) bs->block_status_cache = g_new0(BdrvBlockStatusCache, 1); for (i = 0; i < bdrv_drain_all_count; i++) { - bdrv_drained_begin(bs); + bdrv_do_drained_begin_quiesce(bs, NULL); } QTAILQ_INSERT_TAIL(&all_bdrv_states, bs, bs_list); |