aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2025-06-03 20:47:10 +0200
committerThomas Huth <thuth@redhat.com>2025-06-11 12:17:57 +0200
commit3f11e5f4009f32261806905c37b2d260a9a194f0 (patch)
tree64fc50cc3c2cf001bfcb8402788da9f7c0ce624c
parentb894cc23f8fe6681b8bfc9679a6df1c976e9757a (diff)
downloadqemu-3f11e5f4009f32261806905c37b2d260a9a194f0.zip
qemu-3f11e5f4009f32261806905c37b2d260a9a194f0.tar.gz
qemu-3f11e5f4009f32261806905c37b2d260a9a194f0.tar.bz2
tests/functional: Speed up the avr_mega2560 test
We can simply check for the expected pattern on the console, no need to wait for two seconds here to search for the pattern in the log at the end. While we're at it, also remove the obsolete "timeout" variable from this test. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com> Signed-off-by: Thomas Huth <thuth@redhat.com> Message-ID: <20250603184710.25651-1-thuth@redhat.com>
-rwxr-xr-xtests/functional/test_avr_mega2560.py11
1 files changed, 4 insertions, 7 deletions
diff --git a/tests/functional/test_avr_mega2560.py b/tests/functional/test_avr_mega2560.py
index 8e47b42..6359b72 100755
--- a/tests/functional/test_avr_mega2560.py
+++ b/tests/functional/test_avr_mega2560.py
@@ -18,12 +18,10 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
-import time
+from qemu_test import QemuSystemTest, Asset, wait_for_console_pattern
-from qemu_test import QemuSystemTest, Asset
class AVR6Machine(QemuSystemTest):
- timeout = 5
ASSET_ROM = Asset(('https://github.com/seharris/qemu-avr-tests'
'/raw/36c3e67b8755dcf/free-rtos/Demo'
@@ -40,13 +38,12 @@ class AVR6Machine(QemuSystemTest):
self.set_machine('arduino-mega-2560-v3')
self.vm.add_args('-bios', rom_path)
self.vm.add_args('-nographic')
+ self.vm.set_console()
self.vm.launch()
- time.sleep(2)
- self.vm.shutdown()
+ wait_for_console_pattern(self,
+ 'XABCDEFGHIJKLMNOPQRSTUVWXABCDEFGHIJKLMNOPQRSTUVWXA')
- self.assertIn('ABCDEFGHIJKLMNOPQRSTUVWXABCDEFGHIJKLMNOPQRSTUVWX',
- self.vm.get_log())
if __name__ == '__main__':
QemuSystemTest.main()