aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2024-04-22 14:47:23 +0200
committerMichael Tokarev <mjt@tls.msk.ru>2024-06-20 10:03:40 +0300
commit1798f382428e56fe7e0dbfd9394059dcb8a21b84 (patch)
tree7fc342cad9af41e6a327b7d32b9071f556cadb5b
parentfdbeeb454c9650f0fe96bbb4862d62eadcc33531 (diff)
downloadqemu-1798f382428e56fe7e0dbfd9394059dcb8a21b84.zip
qemu-1798f382428e56fe7e0dbfd9394059dcb8a21b84.tar.gz
qemu-1798f382428e56fe7e0dbfd9394059dcb8a21b84.tar.bz2
hw/audio/virtio-snd: Always use little endian audio format
The VIRTIO Sound Device conforms with the Virtio spec v1.2, thus only use little endianness. Remove the suspicious target_words_bigendian() noticed during code review. Cc: qemu-stable@nongnu.org Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams") Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Message-Id: <20240422211830.25606-1-philmd@linaro.org> (cherry picked from commit a276ec8e2632c9015d0f9b4e47194e4e91dfa8bb) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
-rw-r--r--hw/audio/virtio-snd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
index 823f9ab..092ba23 100644
--- a/hw/audio/virtio-snd.c
+++ b/hw/audio/virtio-snd.c
@@ -401,7 +401,7 @@ static void virtio_snd_get_qemu_audsettings(audsettings *as,
as->nchannels = MIN(AUDIO_MAX_CHANNELS, params->channels);
as->fmt = virtio_snd_get_qemu_format(params->format);
as->freq = virtio_snd_get_qemu_freq(params->rate);
- as->endianness = target_words_bigendian() ? 1 : 0;
+ as->endianness = 0; /* Conforming to VIRTIO 1.0: always little endian. */
}
/*