diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2020-09-24 17:26:55 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2020-10-02 15:46:40 +0200 |
| commit | fefee85da055e100ea86d15274106f78502c2819 (patch) | |
| tree | 20dba3571907c5afbdcaca686646b7bad6dca476 | |
| parent | 1c8222b014484145d66740d0597ae86b4a989b73 (diff) | |
| download | qemu-fefee85da055e100ea86d15274106f78502c2819.zip qemu-fefee85da055e100ea86d15274106f78502c2819.tar.gz qemu-fefee85da055e100ea86d15274106f78502c2819.tar.bz2 | |
nbd: Add writethrough to block-export-add
qemu-nbd allows use of writethrough cache modes, which mean that write
requests made through NBD will cause a flush before they complete.
Expose the same functionality in block-export-add.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200924152717.287415-10-kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | blockdev-nbd.c | 6 | ||||
| -rw-r--r-- | qapi/block-export.json | 7 |
2 files changed, 11 insertions, 2 deletions
diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 41d5542..09247a8 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -216,9 +216,13 @@ BlockExport *nbd_export_create(BlockExportOptions *exp_args, Error **errp) goto out; } + if (!exp_args->has_writethrough) { + exp_args->writethrough = false; + } + exp = nbd_export_new(bs, arg->name, arg->description, arg->bitmap, !arg->writable, !arg->writable, - NULL, false, errp); + NULL, exp_args->writethrough, errp); if (!exp) { goto out; } diff --git a/qapi/block-export.json b/qapi/block-export.json index 8aa8a01..ce66f27 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -170,10 +170,15 @@ # Describes a block export, i.e. how single node should be exported on an # external interface. # +# @writethrough: If true, caches are flushed after every write request to the +# export before completion is signalled. (since: 5.2; +# default: false) +# # Since: 4.2 ## { 'union': 'BlockExportOptions', - 'base': { 'type': 'BlockExportType' }, + 'base': { 'type': 'BlockExportType', + '*writethrough': 'bool' }, 'discriminator': 'type', 'data': { 'nbd': 'BlockExportOptionsNbd' |