diff options
| author | Vincent Fu <vincentfu@gmail.com> | 2024-05-03 13:50:04 -0400 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2024-07-12 21:50:35 +0300 |
| commit | e0d660aeeab08c1566d192cf624f59023386d951 (patch) | |
| tree | b191b7013cb10e933a0cd36d7f94d875a0a4c2b2 | |
| parent | e4a9b44f7aa8872a67a54a71da474626cdbb830a (diff) | |
| download | qemu-e0d660aeeab08c1566d192cf624f59023386d951.zip qemu-e0d660aeeab08c1566d192cf624f59023386d951.tar.gz qemu-e0d660aeeab08c1566d192cf624f59023386d951.tar.bz2 | |
hw/nvme: fix number of PIDs for FDP RUH update
The number of PIDs is in the upper 16 bits of cdw10. So we need to
right-shift by 16 bits instead of only a single bit.
Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Cc: qemu-stable@nongnu.org
Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
(cherry picked from commit 3936bbdf9a2e9233875f850c7576c79d06add261)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| -rw-r--r-- | hw/nvme/ctrl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 127c3d2..e89f9f7 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4352,7 +4352,7 @@ static uint16_t nvme_io_mgmt_send_ruh_update(NvmeCtrl *n, NvmeRequest *req) NvmeNamespace *ns = req->ns; uint32_t cdw10 = le32_to_cpu(cmd->cdw10); uint16_t ret = NVME_SUCCESS; - uint32_t npid = (cdw10 >> 1) + 1; + uint32_t npid = (cdw10 >> 16) + 1; unsigned int i = 0; g_autofree uint16_t *pids = NULL; uint32_t maxnpid; |