aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicholas Piggin <npiggin@gmail.com>2023-08-08 14:19:44 +1000
committerMichael Tokarev <mjt@tls.msk.ru>2023-09-10 19:39:41 +0300
commitea25506b5d6439c76a3a6b7b55dd3f861e98eb85 (patch)
tree48e2a7c7e3da35749e767feb615a9152f99f7aac
parentfcb49ea23c39dd93b8e1d4e0edae67967d28e001 (diff)
downloadqemu-ea25506b5d6439c76a3a6b7b55dd3f861e98eb85.zip
qemu-ea25506b5d6439c76a3a6b7b55dd3f861e98eb85.tar.gz
qemu-ea25506b5d6439c76a3a6b7b55dd3f861e98eb85.tar.bz2
ppc/vof: Fix missed fields in VOF cleanup
Failing to reset the of_instance_last makes ihandle allocation continue to increase, which causes record-replay replay fail to match the recorded trace. Not resetting claimed_base makes VOF eventually run out of memory after some resets. Cc: Alexey Kardashevskiy <aik@ozlabs.ru> Fixes: fc8c745d501 ("spapr: Implement Open Firmware client interface") Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru> Signed-off-by: Cédric Le Goater <clg@kaod.org> (cherry picked from commit 7b8589d7ce7e23f26ff53338d575a5cbd7818e28) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
-rw-r--r--hw/ppc/vof.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c
index 18c3f92..e3b430a 100644
--- a/hw/ppc/vof.c
+++ b/hw/ppc/vof.c
@@ -1024,6 +1024,8 @@ void vof_cleanup(Vof *vof)
}
vof->claimed = NULL;
vof->of_instances = NULL;
+ vof->of_instance_last = 0;
+ vof->claimed_base = 0;
}
void vof_build_dt(void *fdt, Vof *vof)