diff options
| author | Matt Borgerson <contact@mborgerson.com> | 2023-07-13 00:29:01 -0700 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2023-08-05 20:49:49 +0300 |
| commit | 7cb0210fcc50606e1096d315cedf0a3adb2d5243 (patch) | |
| tree | 2c134bb630bc5df2e0fc8ffcda05e6a570758d7c | |
| parent | 979cdfbbfd72bb8a74a420048082990b9da7cc60 (diff) | |
| download | qemu-7cb0210fcc50606e1096d315cedf0a3adb2d5243.zip qemu-7cb0210fcc50606e1096d315cedf0a3adb2d5243.tar.gz qemu-7cb0210fcc50606e1096d315cedf0a3adb2d5243.tar.bz2 | |
target/i386: Check CR0.TS before enter_mmx
When CR0.TS=1, execution of x87 FPU, MMX, and some SSE instructions will
cause a Device Not Available (DNA) exception (#NM). System software uses
this exception event to lazily context switch FPU state.
Before this patch, enter_mmx helpers may be generated just before #NM
generation, prematurely resetting FPU state before the guest has a
chance to save it.
Signed-off-by: Matt Borgerson <contact@mborgerson.com>
Message-ID: <CADc=-s5F10muEhLs4f3mxqsEPAHWj0XFfOC2sfFMVHrk9fcpMg@mail.gmail.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit b2ea6450d8e1336a33eb958ccc64604bc35a43dd)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| -rw-r--r-- | target/i386/tcg/decode-new.c.inc | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc index 48fefaf..e7fa5e9 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1802,16 +1802,18 @@ static void disas_insn_new(DisasContext *s, CPUState *cpu, int b) } break; - case X86_SPECIAL_MMX: - if (!(s->prefix & (PREFIX_REPZ | PREFIX_REPNZ | PREFIX_DATA))) { - gen_helper_enter_mmx(cpu_env); - } + default: break; } if (!validate_vex(s, &decode)) { return; } + if (decode.e.special == X86_SPECIAL_MMX && + !(s->prefix & (PREFIX_REPZ | PREFIX_REPNZ | PREFIX_DATA))) { + gen_helper_enter_mmx(cpu_env); + } + if (decode.op[0].has_ea || decode.op[1].has_ea || decode.op[2].has_ea) { gen_load_ea(s, &decode.mem, decode.e.vex_class == 12); } |