aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcel Apfelbaum <marcel.apfelbaum@gmail.com>2021-06-30 14:52:46 +0300
committerMichael Roth <michael.roth@amd.com>2021-10-17 20:27:51 -0500
commit27c6f20d9d8725ddd4d0744022c4a66ec4878c6d (patch)
treee0e9e3c5995eb5e13bd6deacab823bc07097149f
parent46d3c9e9f5b067a784f24a40134ed9a97e145094 (diff)
downloadqemu-27c6f20d9d8725ddd4d0744022c4a66ec4878c6d.zip
qemu-27c6f20d9d8725ddd4d0744022c4a66ec4878c6d.tar.gz
qemu-27c6f20d9d8725ddd4d0744022c4a66ec4878c6d.tar.bz2
pvrdma: Fix the ring init error flow (CVE-2021-3608)
Do not unmap uninitialized dma addresses. Fixes: CVE-2021-3608 Reviewed-by: VictorV (Kunlun Lab) <vv474172261@gmail.com> Tested-by: VictorV (Kunlun Lab) <vv474172261@gmail.com> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com> Message-Id: <20210630115246.2178219-1-marcel@redhat.com> Tested-by: Yuval Shaia <yuval.shaia.ml@gmail.com> Reviewed-by: Yuval Shaia <yuval.shaia.ml@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (cherry picked from commit 66ae37d8cc313f89272e711174a846a229bcdbd3) Signed-off-by: Michael Roth <michael.roth@amd.com>
-rw-r--r--hw/rdma/vmw/pvrdma_dev_ring.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b/hw/rdma/vmw/pvrdma_dev_ring.c
index 074ac59..4213066 100644
--- a/hw/rdma/vmw/pvrdma_dev_ring.c
+++ b/hw/rdma/vmw/pvrdma_dev_ring.c
@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,
qatomic_set(&ring->ring_state->cons_head, 0);
*/
ring->npages = npages;
- ring->pages = g_malloc(npages * sizeof(void *));
+ ring->pages = g_malloc0(npages * sizeof(void *));
for (i = 0; i < npages; i++) {
if (!tbl[i]) {