aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2019-12-06 14:38:11 +0000
committerMichael Roth <mdroth@linux.vnet.ibm.com>2020-05-11 14:51:51 -0500
commitd636d64b3509ae1cd93931ca3b1ab13afe72ff62 (patch)
treec0f84caee62a08ba167d7c46ffbf1a980bab2b96
parentbed590f2b849ad548d659942771d824c288c6a50 (diff)
downloadqemu-d636d64b3509ae1cd93931ca3b1ab13afe72ff62.zip
qemu-d636d64b3509ae1cd93931ca3b1ab13afe72ff62.tar.gz
qemu-d636d64b3509ae1cd93931ca3b1ab13afe72ff62.tar.bz2
qapi: better document NVMe blockdev @device parameter
Mention that this is a PCI device address & give the format it is expected in. Also mention that it must be first unbound from any host kernel driver. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> (cherry picked from commit ecaf647f300d69271c245a67adca9c3a89d9463a) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
-rw-r--r--qapi/block-core.json6
1 files changed, 5 insertions, 1 deletions
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fe..fcb52ec2 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2963,9 +2963,13 @@
#
# Driver specific block device options for the NVMe backend.
#
-# @device: controller address of the NVMe device.
+# @device: PCI controller address of the NVMe device in
+# format hhhh:bb:ss.f (host:bus:slot.function)
# @namespace: namespace number of the device, starting from 1.
#
+# Note that the PCI @device must have been unbound from any host
+# kernel driver before instructing QEMU to add the blockdev.
+#
# Since: 2.12
##
{ 'struct': 'BlockdevOptionsNVMe',