diff options
| author | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2020-03-23 12:08:22 +0000 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2020-06-22 12:52:12 -0500 |
| commit | 674d3822250a8830fb8e9720ce499f2e8cef6a88 (patch) | |
| tree | 9f08da5462b95afe92f4ab63259cbc62db366b0b | |
| parent | 5ff78dc9bcf2a81f097f1137e58f9a0759347d91 (diff) | |
| download | qemu-674d3822250a8830fb8e9720ce499f2e8cef6a88.zip qemu-674d3822250a8830fb8e9720ce499f2e8cef6a88.tar.gz qemu-674d3822250a8830fb8e9720ce499f2e8cef6a88.tar.bz2 | |
hmp/vnc: Fix info vnc list leak
We're iterating the list, and then freeing the iteration pointer rather
than the list head.
Fixes: 0a9667ecdb6d ("hmp: Update info vnc")
Reported-by: Coverity (CID 1421932)
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200323120822.51266-1-dgilbert@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(cherry picked from commit d4ff109373ce871928c7e9ef648973eba642b484)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
| -rw-r--r-- | monitor/hmp-cmds.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index b2551c1..2fdc84e 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -729,10 +729,11 @@ static void hmp_info_vnc_servers(Monitor *mon, VncServerInfo2List *server) void hmp_info_vnc(Monitor *mon, const QDict *qdict) { - VncInfo2List *info2l; + VncInfo2List *info2l, *info2l_head; Error *err = NULL; info2l = qmp_query_vnc_servers(&err); + info2l_head = info2l; if (err) { hmp_handle_error(mon, &err); return; @@ -761,7 +762,7 @@ void hmp_info_vnc(Monitor *mon, const QDict *qdict) info2l = info2l->next; } - qapi_free_VncInfo2List(info2l); + qapi_free_VncInfo2List(info2l_head); } #endif |