diff options
author | Daniel P. Berrange <berrange@redhat.com> | 2017-12-18 19:12:19 +0000 |
---|---|---|
committer | Gerd Hoffmann <kraxel@redhat.com> | 2018-01-12 13:48:54 +0100 |
commit | 3541b08475d51bddf8aded36576a0ff5a547a978 (patch) | |
tree | 039b6e3a4b9820efa5af8add06e0166d876b3ca4 | |
parent | b939eb89b6f320544a9328fa908d881d0024c1ee (diff) | |
download | qemu-3541b08475d51bddf8aded36576a0ff5a547a978.zip qemu-3541b08475d51bddf8aded36576a0ff5a547a978.tar.gz qemu-3541b08475d51bddf8aded36576a0ff5a547a978.tar.bz2 |
ui: avoid pointless VNC updates if framebuffer isn't dirty
The vnc_update_client() method checks the 'has_dirty' flag to see if there are
dirty regions that are pending to send to the client. Regardless of this flag,
if a forced update is requested, updates must be sent. For unknown reasons
though, the code also tries to sent updates if audio capture is enabled. This
makes no sense as audio capture state does not impact framebuffer contents, so
this check is removed.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-5-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
-rw-r--r-- | ui/vnc.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -984,7 +984,7 @@ static int vnc_update_client(VncState *vs, int has_dirty) return 0; } - if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) { + if (!vs->has_dirty && !vs->force_update) { return 0; } |