aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2011-06-22 15:40:06 +0100
committerBlue Swirl <blauwirbel@gmail.com>2011-07-16 13:17:36 +0000
commit107a47cc2dac1b6c5edae0121831713161cb70c5 (patch)
tree00e636e41c55b106342ffc8137d5d843b3e02fe1
parentcf973e469bd9d47c0460347764c1315a6180e13c (diff)
downloadqemu-107a47cc2dac1b6c5edae0121831713161cb70c5.zip
qemu-107a47cc2dac1b6c5edae0121831713161cb70c5.tar.gz
qemu-107a47cc2dac1b6c5edae0121831713161cb70c5.tar.bz2
tcg/README: Expand advice on number of TCG ops per target insn
Expand the note on the number of TCG ops generated per target insn, to be clearer about the range of applicability of the 20 op rule of thumb. Also add a note about the hard MAX_OP_PER_INSTR limit. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
-rw-r--r--tcg/README10
1 files changed, 9 insertions, 1 deletions
diff --git a/tcg/README b/tcg/README
index 6600122..cfdfd96 100644
--- a/tcg/README
+++ b/tcg/README
@@ -504,7 +504,15 @@ register.
- Don't hesitate to use helpers for complicated or seldom used target
instructions. There is little performance advantage in using TCG to
implement target instructions taking more than about twenty TCG
- instructions.
+ instructions. Note that this rule of thumb is more applicable to
+ helpers doing complex logic or arithmetic, where the C compiler has
+ scope to do a good job of optimisation; it is less relevant where
+ the instruction is mostly doing loads and stores, and in those cases
+ inline TCG may still be faster for longer sequences.
+
+- The hard limit on the number of TCG instructions you can generate
+ per target instruction is set by MAX_OP_PER_INSTR in exec-all.h --
+ you cannot exceed this without risking a buffer overrun.
- Use the 'discard' instruction if you know that TCG won't be able to
prove that a given global is "dead" at a given program point. The