diff options
| author | Benjamin Poirier <benjamin.poirier@gmail.com> | 2011-04-20 19:39:02 -0400 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2011-04-25 22:17:56 +0200 |
| commit | ec48c7747acd1be25ca70586bc4e6640765e40c8 (patch) | |
| tree | 8f7f11eb6e9521ecaa9fbd70e41eaf15f738503e | |
| parent | 7cdeb319e46b8aeef866e17119093e1646e77b02 (diff) | |
| download | qemu-ec48c7747acd1be25ca70586bc4e6640765e40c8.zip qemu-ec48c7747acd1be25ca70586bc4e6640765e40c8.tar.gz qemu-ec48c7747acd1be25ca70586bc4e6640765e40c8.tar.bz2 | |
rtl8139: add format attribute to DPRINTF
gcc can check the format string for correctness even when debugging output is
not enabled.
Have to make sure arguments are always available. They are optimized out if
unneeded.
Signed-off-by: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
| -rw-r--r-- | hw/rtl8139.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 13b14e4..cbf667a 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -88,7 +88,11 @@ # define DPRINTF(fmt, ...) \ do { fprintf(stderr, "RTL8139: " fmt, ## __VA_ARGS__); } while (0) #else -# define DPRINTF(fmt, ...) do { } while (0) +static inline __attribute__ ((format (printf, 1, 2))) + int DPRINTF(const char *fmt, ...) +{ + return 0; +} #endif /* Symbolic offsets to registers. */ @@ -2201,9 +2205,8 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) if ((txdw0 & CP_TX_LGSEN) && ip_protocol == IP_PROTO_TCP) { -#if defined (DEBUG_RTL8139) int large_send_mss = (txdw0 >> 16) & CP_TC_LGSEN_MSS_MASK; -#endif + DPRINTF("+++ C+ mode offloaded task TSO MTU=%d IP data %d " "frame data %d specified MSS=%d\n", ETH_MTU, ip_data_len, saved_size - ETH_HLEN, large_send_mss); |