aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2019-09-25 20:32:29 +0200
committerMax Reitz <mreitz@redhat.com>2019-10-10 10:56:18 +0200
commite6e8db0337307eb600d0903adea44eaa7ff14cc3 (patch)
tree2829a5fff1ca5ee4e2f6404df03d3cd69cb44d58
parentd924559953c0b679582548d8fd8af025667051e3 (diff)
downloadqemu-e6e8db0337307eb600d0903adea44eaa7ff14cc3.zip
qemu-e6e8db0337307eb600d0903adea44eaa7ff14cc3.tar.gz
qemu-e6e8db0337307eb600d0903adea44eaa7ff14cc3.tar.bz2
iotests: Fix 125 for growth_mode = metadata
If we use growth_mode = metadata, it is very much possible that the file uses more disk space after we have written something to the added area. We did indeed want to test for this case, but unfortunately we evidently just copied the code from the "Test creation preallocation" section and forgot to replace "$create_mode" by "$growth_mode". We never noticed because we only read the first number from qemu-img info's "disk size" output -- and that is effectively useless, because qemu-img prints a human-readable value (which generally includes a decimal point). That will be fixed in the patch after the next one. Signed-off-by: Max Reitz <mreitz@redhat.com> Message-id: 20190925183231.11196-2-mreitz@redhat.com Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Max Reitz <mreitz@redhat.com>
-rwxr-xr-xtests/qemu-iotests/1252
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/125 b/tests/qemu-iotests/125
index dc4b8f5..df328a6 100755
--- a/tests/qemu-iotests/125
+++ b/tests/qemu-iotests/125
@@ -111,7 +111,7 @@ for GROWTH_SIZE in 16 48 80; do
if [ $file_length_2 -gt $file_length_1 ]; then
echo "ERROR (grow): Image length has grown from $file_length_1 to $file_length_2"
fi
- if [ $create_mode != metadata ]; then
+ if [ $growth_mode != metadata ]; then
# The host size should not have grown either
if [ $host_size_2 -gt $host_size_1 ]; then
echo "ERROR (grow): Host size has grown from $host_size_1 to $host_size_2"