aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBALATON Zoltan <balaton@eik.bme.hu>2022-04-23 11:36:57 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2022-05-25 21:26:35 +0200
commitdafea9e2868a5349bb0f1650dd18fa1aac806ee4 (patch)
tree7e9787ccc7d6d1c4c056aaa29645b6a86893450d
parentab9f0f7d44d6795050187b3bb0fc28fe804a062b (diff)
downloadqemu-dafea9e2868a5349bb0f1650dd18fa1aac806ee4.zip
qemu-dafea9e2868a5349bb0f1650dd18fa1aac806ee4.tar.gz
qemu-dafea9e2868a5349bb0f1650dd18fa1aac806ee4.tar.bz2
hw/audio/ac97: Remove unimplemented reset functions
The warm_reset() and cold_reset() functions are not implemented and do nothing so no point in calling them or keep around as dead code. Therefore remove them for now. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> Reviewed-by: VĂ­ctor Colombo <victor.colombo@eldorado.org.br> Message-Id: <cc6e99fd498a9ae358ebce787fc04ab6e8201879.1650706617.git.balaton@eik.bme.hu> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--hw/audio/ac97.c17
1 files changed, 1 insertions, 16 deletions
diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index 6b1c12b..6584aa7 100644
--- a/hw/audio/ac97.c
+++ b/hw/audio/ac97.c
@@ -222,16 +222,6 @@ static void po_callback(void *opaque, int free);
static void pi_callback(void *opaque, int avail);
static void mc_callback(void *opaque, int avail);
-static void warm_reset(AC97LinkState *s)
-{
- (void)s;
-}
-
-static void cold_reset(AC97LinkState *s)
-{
- (void)s;
-}
-
static void fetch_bd(AC97LinkState *s, AC97BusMasterRegs *r)
{
uint8_t b[8];
@@ -921,12 +911,7 @@ static void nabm_writel(void *opaque, uint32_t addr, uint32_t val)
dolog("BDBAR[%d] <- 0x%x (bdbar 0x%x)\n", GET_BM(index), val, r->bdbar);
break;
case GLOB_CNT:
- if (val & GC_WR) {
- warm_reset(s);
- }
- if (val & GC_CR) {
- cold_reset(s);
- }
+ /* TODO: Handle WR or CR being set (warm/cold reset requests) */
if (!(val & (GC_WR | GC_CR))) {
s->glob_cnt = val & GC_VALID_MASK;
}