diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-06-10 07:31:52 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-06-15 21:36:30 +0200 |
| commit | da9630c57ee386f8beb571ba6bb4a98d546c42ca (patch) | |
| tree | 73bf72268f5407c35ec9fe9f74c10317e75b1124 | |
| parent | 9e1b990c2ee6e1b14f9abdf5ab325ff2cf9d8bd5 (diff) | |
| download | qemu-da9630c57ee386f8beb571ba6bb4a98d546c42ca.zip qemu-da9630c57ee386f8beb571ba6bb4a98d546c42ca.tar.gz qemu-da9630c57ee386f8beb571ba6bb4a98d546c42ca.tar.bz2 | |
Revert "hw/versatile: realize the PCI root bus as part of the versatile init"
This reverts commit b1af7959a66610669e1a019b9a84f6ed3a7936c6.
Realizing a device automatically realizes its buses, in
device_set_realized(). Realizing them in realize methods is
redundant, unless the methods themselves require them to be realized
early. pci_vpb_realize() doesn't. Drop the redundant bus
realization.
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-4-armbru@redhat.com>
| -rw-r--r-- | hw/pci-host/versatile.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index 8ddfb87..ea7390c 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -459,7 +459,6 @@ static void pci_vpb_realize(DeviceState *dev, Error **errp) } /* TODO Remove once realize propagates to child devices. */ - object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp); object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp); } |