diff options
| author | Markus Armbruster <armbru@redhat.com> | 2022-10-12 17:37:58 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2022-10-27 07:54:45 +0200 |
| commit | 3f7febc93785bf0e622072b01f846d2acbcd9c0b (patch) | |
| tree | 99fecb8db9b01b99bb7ab8a9c9704ae1f720be63 | |
| parent | 344744e148e6e865f5a57e745b02a87e5ea534ad (diff) | |
| download | qemu-3f7febc93785bf0e622072b01f846d2acbcd9c0b.zip qemu-3f7febc93785bf0e622072b01f846d2acbcd9c0b.tar.gz qemu-3f7febc93785bf0e622072b01f846d2acbcd9c0b.tar.bz2 | |
qom: Improve error messages when property has no getter or setter
When you try to set a property that has no setter, the error message
blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio
QEMU 7.1.50 monitor - type 'help' for more information
(qemu) qom-set /machine type q35
Error: Insufficient permission to perform this operation
This implies it could work with "sufficient permission". It can't.
Change the error message to:
Error: Property 'pc-i440fx-7.2-machine.type' is not writable
Do the same for getting a property that has no getter.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221012153801.2604340-2-armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
| -rw-r--r-- | qom/object.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/qom/object.c b/qom/object.c index d346085..e5cef30 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1383,7 +1383,8 @@ bool object_property_get(Object *obj, const char *name, Visitor *v, } if (!prop->get) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property '%s.%s' is not readable", + object_get_typename(obj), name); return false; } prop->get(obj, v, name, prop->opaque, &err); @@ -1402,7 +1403,8 @@ bool object_property_set(Object *obj, const char *name, Visitor *v, } if (!prop->set) { - error_setg(errp, QERR_PERMISSION_DENIED); + error_setg(errp, "Property '%s.%s' is not writable", + object_get_typename(obj), name); return false; } prop->set(obj, v, name, prop->opaque, errp); |