diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2018-04-26 11:04:38 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2018-04-26 11:04:38 +0100 |
| commit | 145772707fe80395b87c244ccf5699a756f1946b (patch) | |
| tree | c684db223219c768705f512fba048107d7cbd242 | |
| parent | 75ed2c02484101d5b4995c56e78a894ac244ce05 (diff) | |
| download | qemu-145772707fe80395b87c244ccf5699a756f1946b.zip qemu-145772707fe80395b87c244ccf5699a756f1946b.tar.gz qemu-145772707fe80395b87c244ccf5699a756f1946b.tar.bz2 | |
target/arm: Remove stale TODO comment
Remove a stale TODO comment -- we have now made the arm_ldl_ptw()
and arm_ldq_ptw() functions propagate physical memory read errors
out to their callers.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180419142151.9862-1-peter.maydell@linaro.org
| -rw-r--r-- | target/arm/helper.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/target/arm/helper.c b/target/arm/helper.c index b14fdab..3ad0371 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8680,13 +8680,7 @@ static hwaddr S1_ptw_translate(CPUARMState *env, ARMMMUIdx mmu_idx, return addr; } -/* All loads done in the course of a page table walk go through here. - * TODO: rather than ignoring errors from physical memory reads (which - * are external aborts in ARM terminology) we should propagate this - * error out so that we can turn it into a Data Abort if this walk - * was being done for a CPU load/store or an address translation instruction - * (but not if it was for a debug access). - */ +/* All loads done in the course of a page table walk go through here. */ static uint32_t arm_ldl_ptw(CPUState *cs, hwaddr addr, bool is_secure, ARMMMUIdx mmu_idx, ARMMMUFaultInfo *fi) { |