diff options
| author | Stefano Stabellini <sstabellini@kernel.org> | 2017-05-09 12:04:53 -0700 |
|---|---|---|
| committer | Stefano Stabellini <sstabellini@kernel.org> | 2017-05-16 11:51:25 -0700 |
| commit | 01cd90b641e1aed40cf13a577e6a737af94d55e7 (patch) | |
| tree | a7990f0fee16df75f5866067a127fc545cc48965 | |
| parent | c0c24b95542bc1a4dc3fc6ea71475ae04fa69189 (diff) | |
| download | qemu-01cd90b641e1aed40cf13a577e6a737af94d55e7.zip qemu-01cd90b641e1aed40cf13a577e6a737af94d55e7.tar.gz qemu-01cd90b641e1aed40cf13a577e6a737af94d55e7.tar.bz2 | |
xen: call qemu_set_cloexec instead of fcntl
Use the common utility function, which contains checks on return values
and first calls F_GETFD as recommended by POSIX.1-2001, instead of
manually calling fcntl.
CID: 1374831
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
CC: anthony.perard@citrix.com
CC: groug@kaod.org
CC: aneesh.kumar@linux.vnet.ibm.com
CC: Eric Blake <eblake@redhat.com>
| -rw-r--r-- | hw/9pfs/xen-9p-backend.c | 2 | ||||
| -rw-r--r-- | hw/xen/xen_backend.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index a1fdede..5df97c9 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -380,7 +380,7 @@ static int xen_9pfs_connect(struct XenDevice *xendev) if (xen_9pdev->rings[i].evtchndev == NULL) { goto out; } - fcntl(xenevtchn_fd(xen_9pdev->rings[i].evtchndev), F_SETFD, FD_CLOEXEC); + qemu_set_cloexec(xenevtchn_fd(xen_9pdev->rings[i].evtchndev)); xen_9pdev->rings[i].local_port = xenevtchn_bind_interdomain (xen_9pdev->rings[i].evtchndev, xendev->dom, diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index c85f163..2cac47d 100644 --- a/hw/xen/xen_backend.c +++ b/hw/xen/xen_backend.c @@ -147,7 +147,7 @@ static struct XenDevice *xen_be_get_xendev(const char *type, int dom, int dev, qdev_unplug(DEVICE(xendev), NULL); return NULL; } - fcntl(xenevtchn_fd(xendev->evtchndev), F_SETFD, FD_CLOEXEC); + qemu_set_cloexec(xenevtchn_fd(xendev->evtchndev)); if (ops->flags & DEVOPS_FLAG_NEED_GNTDEV) { xendev->gnttabdev = xengnttab_open(NULL, 0); |