From 423801e35d048187d88fcbff55e20c4c34d27bee Mon Sep 17 00:00:00 2001 From: Andrew Waterman Date: Wed, 4 Aug 2021 16:40:57 -0700 Subject: Revert "machine: fix a case of undefined behaviour with SP handling (#245)" This reverts commit 5450c2f731f16abe3a4f244c383c55f559c97359. --- machine/mtrap.h | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/machine/mtrap.h b/machine/mtrap.h index e9ef139..a8dbeff 100644 --- a/machine/mtrap.h +++ b/machine/mtrap.h @@ -48,14 +48,9 @@ typedef struct { volatile uint32_t* plic_s_ie; } hls_t; -#define STACK_POINTER() ({ \ - uintptr_t __sp; \ - __asm__("mv %0, sp" : "=r"(__sp)); \ - __sp; \ -}) - -#define MACHINE_STACK_TOP() \ - ({ (void*)((STACK_POINTER() + RISCV_PGSIZE) & -RISCV_PGSIZE); }) +#define MACHINE_STACK_TOP() ({ \ + register uintptr_t sp asm ("sp"); \ + (void*)((sp + RISCV_PGSIZE) & -RISCV_PGSIZE); }) // hart-local storage, at top of stack #define HLS() ((hls_t*)(MACHINE_STACK_TOP() - HLS_SIZE)) -- cgit v1.1