From e42f66d00f450a643e1920aa28037188aa1f2f7c Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Sat, 19 Mar 2016 13:21:18 +0100 Subject: Remove ill-advised cygwin_props Cygwin_props have been invented to allow switching off the unique installation keys in the first place, supposedly for debugging. This never really was a good idea, after all we *want* the installations to be independent and there's no good reason to break that, not even for debugging purposes. Other than that, cygwin_props were meant to be used for some other global settings which never took place. There's just no good reason to tweak the DLL binary invisibly where a setting could be done in a file or the environment. This patch removes the cygwin_props entirely, including the related settings in cygcheck. cygwin: * cygprops.h: Remove file. * globals.cc (cygwin_props): Remove. * cygheap.cc (init_cygheap::init_installation_root): Drop removing installation key. utils: * cygcheck.cc: Drop including cygprops.h. Remove now unused option values. (unique_object_name_opt): Remove. (handle_unique_object_name): Remove function. (usage): Remove text for unique-object-names options. (longopts): Remove unique-object-names options. (main): Drop handling unique-object-names options. doc: * utils.xml (cygcheck): Remove text for unique-object-names options. Signed-off-by: Corinna Vinschen --- winsup/cygwin/globals.cc | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'winsup/cygwin/globals.cc') diff --git a/winsup/cygwin/globals.cc b/winsup/cygwin/globals.cc index 80e0f0d..990158e 100644 --- a/winsup/cygwin/globals.cc +++ b/winsup/cygwin/globals.cc @@ -13,7 +13,6 @@ details. */ #include "winsup.h" #include "cygtls.h" #include "perprocess.h" -#include "cygprops.h" #include "thread.h" #include #include @@ -160,19 +159,6 @@ const int __collate_load_error = 0; extern UNICODE_STRING _RDATA ro_u_natdev = _ROU (L"Device"); #undef _ROU - /* Cygwin properties are meant to be readonly data placed in the DLL, but - which can be changed by external tools to make adjustments to the - behaviour of a DLL based on the binary of the DLL itself. This is - different from $CYGWIN since it only affects that very DLL, not all - DLLs which have access to the $CYGWIN environment variable. We use the - same _RDATA trick as for the above UNICODE_STRINGs. */ - extern cygwin_props_t _RDATA cygwin_props = - { - CYGWIN_PROPS_MAGIC, - sizeof (cygwin_props_t), - 0 - }; - /* This is an exported copy of environ which can be used by DLLs which use cygwin.dll. */ char **__cygwin_environ; -- cgit v1.1