From 65f7ab0bb928162f6a6ea60e2803d6b9e5d95e8b Mon Sep 17 00:00:00 2001 From: Kuan-Wei Chiu Date: Sat, 2 Dec 2023 00:13:21 +0800 Subject: newlib: libc: Fix memory leak in computematchjumps() In cases where malloc fails for the 'g->matchjump' allocation, the code path does not handle the failure gracefully, potentially leading to a memory leak. This fix ensures proper cleanup by freeing the allocated memory for 'pmatches' before returning. Signed-off-by: Kuan-Wei Chiu --- newlib/libc/posix/regcomp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'newlib') diff --git a/newlib/libc/posix/regcomp.c b/newlib/libc/posix/regcomp.c index 002f978..e71bc00 100644 --- a/newlib/libc/posix/regcomp.c +++ b/newlib/libc/posix/regcomp.c @@ -2001,8 +2001,10 @@ struct re_guts *g; } g->matchjump = (int*) malloc(g->mlen * sizeof(unsigned int)); - if (g->matchjump == NULL) /* Not a fatal error */ - return; + if (g->matchjump == NULL) { /* Not a fatal error */ + free(pmatches); + return; + } /* Set maximum possible jump for each character in the pattern */ for (mindex = 0; mindex < g->mlen; mindex++) -- cgit v1.1