From f159663b08f532eb77147abc6f8a65e4c5854773 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Thu, 20 Jan 2022 23:45:23 -0500 Subject: newlib: stop clobbering LDFLAGS with non-standard $ldflags It's unclear why this was added originally, but assuming it was needed 20 years ago, it shouldn't be explicitly required nowadays. Current versions of autotools already take care of exporting LDFLAGS to the Makefile as needed (things are actually getting linked). That's why the configure diffs show LDFLAGS still here, but shifted to a diff place in the output list. A few dirs stop exporting LDFLAGS, but that's because they don't do any linking, only compiling, so it's correct. As for the use of $ldflags instead of the standard $LDFLAGS, I can't really explain that at all. Just use the right name so users don't have to dig into why their setting isn't respected, and then use a non-standard name instead. Adjust the testsuite to match. --- newlib/libc/machine/mn10300/configure | 4 ---- 1 file changed, 4 deletions(-) (limited to 'newlib/libc/machine/mn10300/configure') diff --git a/newlib/libc/machine/mn10300/configure b/newlib/libc/machine/mn10300/configure index 67f976a..acaebf6 100755 --- a/newlib/libc/machine/mn10300/configure +++ b/newlib/libc/machine/mn10300/configure @@ -604,7 +604,6 @@ ELIX_LEVEL_1_FALSE ELIX_LEVEL_1_TRUE ELIX_LEVEL_0_FALSE ELIX_LEVEL_0_TRUE -LDFLAGS NO_INCLUDE_LIST NEWLIB_CFLAGS CCASFLAGS @@ -3536,9 +3535,6 @@ NEWLIB_CFLAGS=${newlib_cflags} NO_INCLUDE_LIST=${noinclude} -LDFLAGS=${ldflags} - - if test x${newlib_elix_level} = x0; then ELIX_LEVEL_0_TRUE= ELIX_LEVEL_0_FALSE='#' -- cgit v1.1