aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-03-12Cygwin: pipe: Make sure to set read pipe non-blocking for cygwin apps.Takashi Yano3-32/+68
If pipe reader is a non-cygwin app first, and cygwin process reads the same pipe after that, the pipe has been set to bclocking mode for the cygwin app. However, the commit 9e4d308cd592 assumes the pipe for cygwin process always is non-blocking mode. With this patch, the pipe mode is reset to non-blocking when cygwin app is started. Addresses: https://cygwin.com/pipermail/cygwin/2024-March/255644.html Fixes: 9e4d308cd592 ("Cygwin: pipe: Adopt FILE_SYNCHRONOUS_IO_NONALERT flag for read pipe.") Reported-by: wh <wh9692@protonmail.com> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-03-11Cygwin: 3.6.0: add release entries for pinned/unpinned flag handlingCorinna Vinschen1-0/+4
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-11Cygwin: add 3.5.2 release entries for latest commitsCorinna Vinschen1-0/+7
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-11Cygwin: getgrent: don't skip SAM-only builtin-accountsCorinna Vinschen2-3/+12
Since commit 15e82eef3a40b ("Cygwin: getgrent: fix local SAM enumeration on domain member machines") we skip enumerating local BUILTIN accounts if we also enumerate AD. However, there are two local accounts which are only available in local SAM, not in AD. Don't skip enumerating those. Fixes: 15e82eef3a40b ("Cygwin: getgrent: fix local SAM enumeration on domain member machines") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-11libc/stdio: Remove wchar_t functions from NEWLIB_NANO_FORMATTED_IOTorbjörn SVENSSON2-471/+471
Regression tested in basepoints/gcc-14-9032-g945cb8490cb with arm-none-eabi. Example failure without this change: $ arm-none-eabi-g++ .../pr100611.C -std=c++20 --specs=nosys.specs -o /dev/null --specs=nano.specs .../ld: .../libc_nano.a(libc_a-svfwprintf.o): in function `_svfwprintf_r': (.text._svfwprintf_r+0xd8): undefined reference to `__ssputws_r' .../ld: (.text._svfwprintf_r+0x834): undefined reference to `__ssputws_r' .../ld: (.text._svfwprintf_r+0x85c): undefined reference to `__ssputws_r' .../ld: (.text._svfwprintf_r+0x8a8): undefined reference to `__ssputws_r' .../ld: (.text._svfwprintf_r+0x8dc): undefined reference to `__ssputws_r' .../ld: .../libc_nano.a(libc_a-svfwprintf.o):(.text._svfwprintf_r+0x900): more undefined references to `__ssputws_r' follow collect2: error: ld returned 1 exit status Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> Co-authored-by: Yvan ROUX <yvan.roux@foss.st.com>
2024-03-08Cygwin: FS_IOC_[GS]ETFLAGS: handle pinned and unpinned attributesCorinna Vinschen5-7/+23
Add FS_PINNED_FL and FS_UNPINNED_FL flags and handle them with mode bits 'p' and 'u' in chattr(1) and lsattr(1). Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-08Cygwin: get/set security descriptors using FILE_OPEN_NO_RECALLCorinna Vinschen1-3/+6
Add FILE_OPEN_NO_RECALL to NtOpenFile calls trying to fetch or write file security descriptors so as not to recall them from offline storage inadvertently. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-08Cygwin: try to avoid recalling offline filesCorinna Vinschen7-12/+62
Chances are high that Cygwin recalls offline files from remote storage, even if the file is only accessed during stat(2) or readdir(3). To avoid this - make sure Cygwin is placeholder-aware, - open files in path_conv handling, as well as in stat(2)/readdir(3) scenarios with FILE_OPEN_NO_RECALL, and - during symlink checking or testing for executablility, don't even try to open the file if one of the OFFLINE attributes is set. Reported-by: Marcin Wisnicki <mwisnicki@gmail.com> Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-07Cygwin: move EXPORT_ALIAS expressions to end of sourceCorinna Vinschen6-24/+19
This isn't strictly required, but it avoids confusion in ctags. Ctags fails to record the next function or method following the EXPORT_ALIAS expression. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-06Cygwin: pipe: Simplify chhecking procedure of query_hdl.Takashi Yano2-28/+24
This patch eliminates verbose NtQueryObject() calls in the procedure to get query_hdl by storing pipe name into fhandler_base::pc when the pipe is created. fhandler_pipe::temporary_query_hdl() uses the storedpipe name rather than the name retrieved by NtQueryObject(). Suggested-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-03-05Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.Takashi Yano2-44/+17
Non-cygwin app may call ReadFile() for empty pipe, which makes NtQueryObject() for ObjectNameInformation block in fhandler_pipe:: get_query_hdl_per_process. Therefore, do not to try to get query_hdl for non-cygwin apps. Addresses: https://github.com/msys2/msys2-runtime/issues/202 Fixes: b531d6b06eeb ("Cygwin: pipe: Introduce temporary query_hdl.") Reported-by: Alisa Sireneva, Johannes Schindelin <Johannes.Schindelin@gmx.de> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-03-04Cygwin: console: Fix a race issue between close() and open().Takashi Yano2-24/+38
The open() call for console sometimes fails if the console owner process is closing the console by close() at the same time. This is due to mismatch state of con.owner variable and attaching state to the console. With this patch, checking con.owner and attaching to con.owner sequence in open(), and resetting con.owner and freeing console sequence in close() are guarded by output_mutex to avoid such a race issue. Addresses: https://cygwin.com/pipermail/cygwin/2024-March/255575.html Fixes: 3721a756b0d8 ("Cygwin: console: Make the console accessible from other terminals.") Reported-by: Kate Deplaix <kit-ty-kate@outlook.com> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-03-01Cygwin: cygheap: compute bucket instead of looping over itCorinna Vinschen2-9/+13
Start at index 0 and use 32 bytes as minimal allocation size. Reduce NBUCKETS, we don't have such big objects on the cygheap anyway. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-01Cygwin: cygheap: use SRWLOCK for cygheap lockingCorinna Vinschen1-7/+6
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-01Cygwin: posix_getdents: do not clear attached DIR structure at fork(2)Corinna Vinschen1-1/+0
The upcoming POSIX issue 8 will require that posix_getdents after fork() will pick up at the right spot, independently of being called in the parent or in the child process. Remove the expression clearing out the attached DIR after fork. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-01Cygwin: lseek: improve seeking posix_getdents descriptorsCorinna Vinschen1-22/+61
Transfer code lseeking on posix_getdents() directory descriptor into its own static function and rework it so SEEK_END, SEEK_DATA and SEEK_HOLE work here as expected, too. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-03-01Cygwin: console: Do not unmap shared console memory belonging to ctty.Takashi Yano2-3/+12
In the condition that console setup for CTTY and close run at the sametime, accessing shared console memory which is already unmapped may occur. With this patch, to avoid this race issue, shared console memory which belongs to contorolling terminal (CTTY) is kept mapped as before. Addresses: https://cygwin.com/pipermail/cygwin/2024-February/255561.html Fixes: 3721a756b0d8 ("Cygwin: console: Make the console accessible from other terminals.") Reported-by: Kate Deplaix <kit-ty-kate@outlook.com> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-28Cygwin: set ENOSHARE and ECASECLASH _sys_errlist[] entries to emptyChristian Franke1-3/+9
These errno values are no longer used by Cygwin. Change the entries to empty strings instead of NULL to avoid crashes in existing binaries directly accessing the table. Enhance strerror_worker() such that empty strings also result in "Unknown error ..." messages. Also add a static_assert check for the _sys_errlist[] size. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-28Cygwin: add compile warning if ENOSHARE or ECASECLASH is usedChristian Franke1-3/+3
These errno values are no longer used by Cygwin. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-26Cygwin: add release text for getgrent local SAM enumeration patchCorinna Vinschen1-0/+2
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-26Cygwin: errmap[]: update comments using current winerror.hChristian Franke1-850/+851
Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-26Cygwin: errmap[]: add error numbers to /* ERROR_... */ commentsChristian Franke1-1357/+1357
Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-26Cygwin: errmap[]: reduce value size from 32 to 8 bitsChristian Franke1-1/+1
Overflow would be detected at compile time. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-26Cygwin: introduce constexpr errmap_size and errmap[] consistency checksChristian Franke2-2/+11
Use constexpr instead of const for errmap[] to allow static_assert checks on its values. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-24Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEVChristian Franke1-2/+2
If a removable (USB) device is disconnected after opening its raw device, R/W attempts fail with ERROR_NO_SUCH_DEVICE(433). If the raw device of a partition is used, ERROR_MEDIA_CHANGED(1110) is returned instead. Both are mapped to ENODEV(19) because <errno.h> does not offer a value which better matches ERROR_MEDIA_CHANGED. Signed-off-by: Christian Franke <christian.franke@t-online.de>
2024-02-24Cygwin: add newgrp release notesCorinna Vinschen1-0/+3
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-24Cygwin: newgrp: only allow group from supplementary group listCorinna Vinschen2-5/+27
Windows only allows to set the primary group to a group already present in the TOKEN_GROUP list. Cygwin OTOH fakes success at setgid() time, to allow a subsequent call to setuid() to do the actual account switching. To have a sane behaviour in the command line tool, check group membership and disallow to switch to groups other than those already present in the user token. Fixes: 8bd56ec873453 ("Cygwin: newgrp: first full version") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-24Cygwin: newgrp: fix invalid usage of argvCorinna Vinschen1-1/+2
Fix an error message accessing argv[1] even after it has been potentially moved. Print group name from group DB instead. Fixes: 8bd56ec873453 ("Cygwin: newgrp: first full version") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-24RTEMS: Define ssize_t for <dirent.h>Sebastian Huber1-0/+5
This fixes the following build issue: newlib/libc/include/dirent.h:84:1: error: unknown type name 'ssize_t'; did you mean '_ssize_t'? 84 | ssize_t posix_getdents(int, void *, size_t, int); | ^~~~~~~ | _ssize_t
2024-02-21Cygwin: strptime: add release noteCorinna Vinschen1-0/+3
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-21Cygwin: strptime: fix am/pm handlingCorinna Vinschen1-3/+9
The %p format specifier is handled immediately. It requires that tm_hour is already set. This falls flat in case the am/pm marker preceeds the time specification. Locales with am/pm marker preceeding time spec by default exist (e. g. ko_KR). Also, the code expects that tm_hour might be set to an invalid value because the %p specifier is used in conjunction with %H. But this usage is invalid in itself and now catched as error condition after commit 343a2a558153 ("Cygwin: strptime: make sure to fail on invalid input digits"). Change the %H/%I/%p handling according to GLibC, i. e. - fix tm_hour for pm only if the time value has been specified as 12 hour time %I, and - perform the fixup only after the entire input has been scanned. This decouples the fixup from the %p position relativ to %I. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-21Cygwin: strptime: make sure to fail on invalid input digitsCorinna Vinschen1-3/+12
conv_num returns NULL if the input is invalid, e. g., the numbers are out of range. However, the code fails to test this in a lot of places. Rather than adding checks all over the place, rename conv_num to __conv_num and create a wrapper macro conv_num to perform the task of error checking. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-21strptime: fix am/pm converting to 24-hour systemAlexey Lapshin1-5/+6
Fix the issue of parsing 08:00AM, which currently gives a 20:00 representation.
2024-02-20Cygwin: getgrent/getpwent: avoid local enumeration on DCsCorinna Vinschen1-0/+5
...if we're supposed to enumerate the AD accounts anyway. This avoids some useless duplication. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-20Cygwin: getgrent: fix local SAM enumeration on domain member machinesCorinna Vinschen2-5/+9
Don't skip output of local SAM groups on domain member machines. They can have valid, user-defined groups in their SAM. Just skip builtin groups if we're enumerating AD as well. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-20Cygwin: passwd/group: drop Capability SIDsCorinna Vinschen1-18/+29
Capability SIDs (S-1-15-3-...) have been introduced with Windows 10 1909. They don't resolve with LookupAccountSid. We don't need them and they don't map gracefully into out POSIX account namespace. Also, add code to make sure to filter them out *iff* they become resolvable at one point. While at it, slightly reorder code for non-resolving SIDs by authority values. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-20Cygwin: gettimeofday: allow tv NULL pointerCorinna Vinschen2-3/+9
Add a missing check for the struct timeval pointer being NULL. Reported-by: 109224573 <109224573@qq.com> Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-16Cygwin: timespec_get: implement C11 functionCorinna Vinschen4-0/+18
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-16Cygwin: pty: Re-fix the last bug regarding nat-pipe.Takashi Yano1-4/+1
Fixes: f907b5f405a3 ("Cygwin: pty: Fix failure to revert from nat-pipe in disable_pcon.") Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-16Cygwin: pty: Fix failure to revert from nat-pipe in disable_pcon.Takashi Yano1-2/+0
Fixes: a9038789488e ("Cygwin: pty: Additional fix for transferring input at exit."); Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-16Cygwin: console: Fix a bug that 64th console cannot be handled.Takashi Yano4-9/+8
Fixes: 930e553da8e9 ("Cygwin: console: Unify EnumWindows() callback functions."); Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-16Cygwin: console: Fix a bug that cannot handle consoles more than 32.Takashi Yano3-2/+4
Fixes: 3721a756b0d8 ("Cygwin: console: Make the console accessible from other terminals.") Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-14Cygwin: console: Unify EnumWindows() callback functions.Takashi Yano4-110/+39
Previously, three similar callback fuctions were used in console code. This patch unifies these functions to ease maintenance cost. Fixes: 8aad3a7edeb2 ("Cygwin: console: Fix a problem that minor ID is incorrect in ConEmu.") Suggested-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-14Cygwin: pty: Make GNU screen and tmux work in ConEmu cygwin-connector.Takashi Yano1-1/+3
Fixes: 3721a756b0d8 ("Cygwin: console: Make the console accessible from other terminals.") Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-14Cygwin: accommodate gcc -Og optionCorinna Vinschen3-3/+3
All three warnings produced with -Og are false positives. But given we're using -Werror unconditionally it's better to be safe than sorry. Reported-by: Kevin Ushey <kevinushey@gmail.com> Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-13Cygwin: find_fast_cwd: don't run assembler checking code on ARM64Corinna Vinschen1-15/+13
https://cygwin.com/pipermail/cygwin/2024-February/255397.html reports a crash on ARM64 probably related to checking x86_64 code on the x86_64 emulator on AArch64. At least for testing, pull the code checking the host HW up to be called before trying to evaluate assembler code. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2024-02-13Cygwin: console: Fix a problem that minor ID is incorrect in ConEmu.Takashi Yano4-0/+30
Previously, minor device number of console was not assigned correctly in ConEmu environment. This is because console window of ConEmu is not enumerated by EnumWindows(). This patch fixes the issue. Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-13Cygwin: console: Make VMIN and VTIME work.Takashi Yano2-8/+20
Previously, VMIN and VTIME did not work at all. This patch fixes that. Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-13Cygwin: pty: Fix potential handle leak regarding CallNamedPipe().Takashi Yano1-2/+18
In pty master_thread, 6 handles are duplicated when CallNamedPipe() requests that. Though some of them are not used so should be closed, they were not. This causes handle leak potentially. Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2024-02-13Cygwin: pty: Fix handle leak in master process.Takashi Yano2-0/+5
If non-cygwin process is started in pty, closing from_master_nat pipe handle was missing in fhandler_pty_slave::input_transfer(). This occured because the handle was duplicated but not closed. https://github.com/msys2/msys2-runtime/issues/198 Fixes: 29431fcb5b14 ("Cygwin: pty: Inherit typeahead data between two input pipes.") Reported-by: Hakkin Lain Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
generated by cgit v1.1 at 2025-09-21 00:40:40 +0000