aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
26 hoursCygwin: handle GetProcAddress returning NULL in GetArm64ProcAddress.HEADgithub/mastergithub/mainmastermainJeremy Drake1-2/+2
This was an oversight, the caller of GetArm64ProcAddress does check for a NULL return, but it would have crashed in the memcmp before getting there. Fixes: 2c5f25035d9f ("Cygwin: add find_fast_cwd_pointer_aarch64.") Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
38 hoursnewlib: riscv: Fix build and reorganize header filesEric Salem6-11/+21
The sys/asm.h header file is included for certain assembly files, so move the typedef to a separate header file due to the build breaking on some systems. Also include the port's string header file (and move and rename) instead of the system's version. Addresses: https://sourceware.org/pipermail/newlib/2025/021591.html Fixes: c3b9bb173c8c ("newlib: riscv: Add XLEN typedef and clean up types") Reported-by: Jeff Law <jlaw@ventanamicro.com> Suggested-by: Kito Cheng <kito.cheng@gmail.com> Signed-off-by: Eric Salem <ericsalem@gmail.com>
2 daysRISC-V: Fix the asm code for large code modelKito Cheng2-1/+47
The large code model assume the data may far away from the code, so we must put the address of the target data wihin the `.text` section, normally we will just put within the function or nearby the function to prevent it out-of-range. Report from riscv-gnu-toolchain: https://github.com/riscv-collab/riscv-gnu-toolchain/issues/1699 Verified with riscv-gnu-toolchain with rv64gc.
3 daysCygwin: add find_fast_cwd_pointer_aarch64.Jeremy Drake3-6/+229
This works for aarch64 hosts when the target is aarch64, x86_64, or i686, with only a small #if block in one function that needs to care. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
3 daysCygwin: use udis86 to find fast cwd pointer on x64Jeremy Drake1-79/+151
This makes find_fast_cwd_pointer more resiliant in the face of changes to the generated code in ntdll. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
3 daysCygwin: patch libudis86 to build as part of CygwinJeremy Drake9-18/+55
This ifdefs out the large table of opcode strings (and the function that references it) since we're only interested in walking machine code, not generating disassembly, and makes a couple of other tables "const" so that they end up in .rdata instead of .data. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
3 daysCygwin: vendor libudis86 1.7.2/libudis86Jeremy Drake8-0/+11287
This does not include the source files responsible for generating AT&T- or Intel-syntax assembly output, or upstream's Makefile.{am,in}. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
3 daysCygwin: factor out find_fast_cwd_pointer to arch-specific file.Jeremy Drake3-117/+134
This is in preparation for rewriting it using udis86, and adding an implementation for aarch64 hosts. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
3 daysCygwin: posix.xml: Mark libacl functions correctlyCorinna Vinschen1-10/+10
The functions defined by libacl, but not in POSIX.1e draft 17, are accidentally documented as POSIX functions. Mark them as libacl functions instead. Fixes: 004e95cf3594 ("Cygwin: winsup/doc/posix.xml: add missing POSIX.1e functions to docs") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
3 daysCygwin: ACLs: Add some useful non-POSIX ACL functions from FreeBSDCorinna Vinschen5-16/+193
Add the following functions: acl_get_fd_np acl_get_link_np acl_get_perm_np acl_is_trivial_np acl_set_fd_np acl_set_link_np acl_strip_np Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
3 daysCygwin: dll::detach: drop declaration of unimplemented methodCorinna Vinschen1-1/+0
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
3 daysCygwin: dlfcn: add native DLLs to dll listCorinna Vinschen4-19/+55
If native DLLs are dlopen'ed, we have to keep track of the load count, so dlclose doesn't misbehave. We also have to keep track for the sake of a forked child so the handle returned by dlopen is still valid in the child. To accomplish that, add a new type DLL_NATIVE. Fixes: 82b31085f6ad ("Cygwin: dlfcn: avoid ENOENT on dlcose after dlopen(cygwin1.dll)") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
3 daysCygwin: pipe: Add workaround for native ninjaTakashi Yano2-1/+8
Native (non-cygwin) ninja creates pipe with size == 0, and starts cygwin process with that pipe. This causes infinite loop in the fhandler_fifo_pipe::raw_write(). Ideally, the pipe implementation in cygwin could work even with pipe size == 0, however, it seems impossible due to: (1) select() does not work for that pipe because PeekNamedPipe() always returns 0. Read side is ready to read only when the write side is about to write, but there is no way to know that. (2) The cause of the problem: https://cygwin.com/pipermail/cygwin/2025-January/257143.html cannot be avoidable. To avoid CancelIo() problem, the patch https://cygwin.com/pipermail/cygwin-patches/2025q1/013451.html restricts the data size less than the current pipe space. However, if pipe size is zero this is impossible. This patch adds just a workaround for native ninja that avoid infinite loop in raw_write(). Addresses: https://github.com/msys2/msys2-runtime/issues/270 Reported-by: Christoph Reiter <reiter.christoph@gmail.com> Co-authored-by: Johannes Schindelin <johannes.schindelin@gmx.de> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
3 daysCygwin: pty: Return EMFILE when too meny ptmx are openedTakashi Yano3-1/+7
Previously, opening /dev/ptmx fails without setting errno when it is opened too many times. With this patch, return EMFILE in that situation. Addresses: https://cygwin.com/pipermail/cygwin/2025-March/257786.html Fixes: 09738c30627c ("Cygwin: pty: setup new pty on opening the master, not in constructor") Reported-by: Christian Franke <christian.franke@t-online.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
3 daysCygwin: exceptions: check ExceptionFlags for EXCEPTION_NONCONTINUABLECorinna Vinschen3-1/+9
So far, exception::handle returned prematurely if the value of EXCEPTION_RECORD::ExceptionFlags was non-0. Starting with Windows 11 we're getting into trouble with that, if the exception is software generated, for instance by calling "throw" in a C++ application. In that case EXCEPTION_SOFTWARE_ORIGINATE (0x80) is set in EXCEPTION_RECORD::ExceptionFlags. Change the condition for exiting prematurely to do this only if any other flag except EXCEPTION_SOFTWARE_ORIGINATE is set in EXCEPTION_RECORD::ExceptionFlags. Fixes: Silent change in Windows exception handling Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
4 daysor1k: Fix compilation for __OR1K_MULTICORE__ buildsStafford Horne2-3/+3
When building newlib for multicore environments we specify __OR1K_MULTICORE__ which switches the build to allocate one struct _or1k_reent per CPU dynamiocally. This was using a strange definition of (*_or1k_reent)[], and causing the following compiler error: ./gnu-toolchain/newlib/libgloss/or1k/impure.c: In function ‘_or1k_reent_init’: ./gnu-toolchain/newlib/libgloss/or1k/impure.c:121:21: error: assignment to ‘struct .. 121 | _or1k_reent = (struct _or1k_reent*) _sbrk_r(0, memsize); | Fix this compiler error by changing the or1k_reent definition to a pointer to structs. Signed-off-by: Stafford Horne <shorne@gmail.com>
4 daysCygwin: faq: add test of fork/exec slowdown by anti-virusChristian Franke1-0/+20
Signed-off-by: Christian Franke <christian.franke@t-online.de>
4 daysCygwin: ACLs: don't allow special accounts as USER entryCorinna Vinschen2-1/+18
While accounts from the BUILTIN, NT AUTHORITY, and NT SERVICE domains can be owner of a file, they are always treated as group entries if they show up as additional entrys in a Windows ACL. Consequentially, it shouldn't be possible to add or remove them as USER entry, for instance, via setfacl. Add a check to disallow BUILTIN, NT AUTHORITY, and NT SERVICE accounts as USER entries in a POSIX ACL. Fixes: bc444e5aa4ca ("Reapply POSIX ACL changes.") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
4 daysCygwin: set_posix_access: Use DEF objects when creating default ACL entries ↵Corinna Vinschen1-2/+2
from scratch When creating default ACL entries from scratch, set_posix_access accidentally sets the type to GROUP_OBJ and OTHER_OBJ, rather than DEF_GROUP_OBJ/DEF_OTHER_OBJ. This shouldn't be noticable most of time since creating from scratch is seldom necessary. Fixes: bc444e5aa4ca ("Reapply POSIX ACL changes.") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
4 daysCygwin: dlopen: rename gmheflags to nodeleteCorinna Vinschen1-7/+6
It's more helpful when reading the source. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
4 daysCygwin: dlfcn: fix dlopen refcounting for DLLs loaded with RTLD_NODELETECorinna Vinschen3-7/+26
Refcounting is performed even if the DLL is loaded at least once with RTLD_NODELETE. In that case we must not decrement the count on dlclose, even if FreeLibrary will never unload the DLL. Use INT_MAX as dll count if RTLD_NODELETE has been used at least once. Skip any further refcounting and make sure the DLL is still pinned in memory after fork. Fixes: 33297d810d90 ("Cygwin: dlfcn: Fix reference counting") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
4 daysCygwin: dlfcn: avoid ENOENT on dlcose after dlopen(cygwin1.dll)Corinna Vinschen4-5/+8
When dlopen'ing the Cygwin DLL, refcounting the number of dlopen calls fails because dll_list::find returns NULL if the address resolves to the Cygwin DLL. Fix this by adding a bool parameter to dll_list::find which allows find to return the dll entry for the Cygwin DLL for the sake of dlopen/dlclose/fork. Fixes: 33297d810d90 ("Cygwin: dlfcn: Fix reference counting") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
6 daysCygwin: testsuite: Fix compilation for arm64Thirumalai Nagalingam3-8/+22
Introduce a cpu_relax.h header to provide architecture-specific processor idling instructions for the`cancel3` and `cancel5` tests.
6 daysCygwin: testsuite: Fix compatibility with GCC 15Thirumalai Nagalingam14-55/+44
GCC 15 defaults to `-std=gnu23`, causing build failures in `testsuite` due to outdated C function declarations. This patch updates the function declarations to align with modern standards.
9 daysCygwin: signal: Copy context to alternate stack in the SA_ONSTACK caseTakashi Yano2-0/+13
After the commit 0210c77311ae, the context passed to signal handler cannot be accessed from the signal handler that uses alternate stack. This is because the context locally copied is on the stack that is different area from the signal handler uses. With this patch, copy the context to alternate signal stack area to avoid this situation. Addresses: https://cygwin.com/pipermail/cygwin/2025-March/257714.html Fixes: 0210c77311ae ("Cygwin: signal: Use context locally copied in call_signal_handler()") Reported-by: Bruno Haible <bruno@clisp.org> Reviewed-by: Corinna Vischen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
9 daysFix GCN SIMD libm bugAndrew Stubbs1-2/+15
Since January, GCC has been miscompiling Newlib libm on AMD GCN due to undefined behaviour in the RESIZE_VECTOR macro. It was "working" but expanding the size of a vector would no longer zero the additional lanes, as it expected. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119325
10 daysCygwin: document getlocalename_l fixesCorinna Vinschen1-0/+4
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
10 daysgetlocalename_l: allow LC_ALL categoryCorinna Vinschen2-3/+17
Following the changes from Austin Group bug https://www.austingroupbugs.net/view.php?id=1741, getlocalename_l() now allows to specify LC_ALL and returns a setlocale-conmpatible LC_ALL locale string. Consequentially we have to raise the size of _reent::_getlocalename_l_buf so there's enough space for the LC_ALL locale string. Guard all different definitions and usages of _getlocalename_l_buf in reent.h with _MB_CAPABLE. Link: https://www.austingroupbugs.net/view.php?id=1741 Fixes: 71511d4ac868 ("getlocalename_l: implement per SUS Base Specifications Issue 8 draft") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
10 dayslocale: drop global_locale_string, add locale_string to locale_tCorinna Vinschen2-22/+29
After 71511d4ac868 ("getlocalename_l: implement per SUS Base Specifications Issue 8 draft") the Austin Group changed the definition of getlocalename_l() to return setlocale-compatible strings if LC_ALL has been specified. In contrast to the former definition which disallowed LC_ALL as category. In preparation, add a locale_string to every locale_t, and drop the static global_locale_string. This in turn requires to change currentlocale() to work locale-agnostic. Rename to __currentlocale and take two parameters, the locale object and a target string to store the locale string. The latter is required to allow specifiying a target string not in the current locale. Link: https://www.austingroupbugs.net/view.php?id=1741 Fixes: 71511d4ac868 ("getlocalename_l: implement per SUS Base Specifications Issue 8 draft") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
10 daysgetlocalename_l: fix commentCorinna Vinschen1-1/+1
Fix name of the defining POSIX standard. Fixes: 71511d4ac868 ("getlocalename_l: implement per SUS Base Specifications Issue 8 draft") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
10 daysgetlocalename_l: fix return value in LC_GLOBAL_LOCALE caseCorinna Vinschen1-2/+2
The data was written to the per-reent getlocalename buffer, but the value wasn't returned. Fixes: 71511d4ac868 ("getlocalename_l: implement per SUS Base Specifications Issue 8 draft") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
10 daysCygwin: ntdll.h: enum _FILE_INFORMATION_CLASS: add FileKnownFolderInformationCorinna Vinschen1-0/+1
...for completeness. Introduced with Windows Server 2022. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
10 daysRevert "Cygwin: CI: XFAIL umask03"Jon Turney1-5/+1
This reverts commit cbe7543cdfdb7f3d270214877d4a4c3e78710bd3.
10 daysCI: Remove inheritable permissions from working directoryJon Turney1-0/+3
Remove inheritable permissions from the working directory, since they break assumptions that the testsuite makes about the filemode a given umask will result in.
10 daysCygwin: signal: Clear direction flag in sigdeleyedTakashi Yano2-0/+4
x86_64 ABI requires the direction flag in CPU flags register cleared. https://learn.microsoft.com/en-us/cpp/build/x64-software-conventions However, currently that flag is not maintained in signal handler. Therefore, if the signal handler is called when that flag is set, it destroys the data and may crash if rep instruction is used in the signal handler. With this patch, the direction flag is cleared in sigdelayed() by adding cld instruction. Addresses: https://cygwin.com/pipermail/cygwin/2025-March/257704.html Fixes: 1fd5e000ace5 ("import winsup-2000-02-17 snapshot") Reported-by: Christian Franke <Christian.Franke@t-online.de> Reviewed-by: Corinna Vischen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
10 daysnewlib: regenerate Makefile.inCorinna Vinschen1-1/+20
A new C file was added to the RISC-V build
10 daysnewlib: riscv: Add stpcpy() portEric Salem4-45/+75
Add implementation of stpcpy() to the RISC-V port. Also refactor shared code between strcpy() and stpcpy() to a common function. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Eric Salem <ericsalem@gmail.com>
10 daysnewlib: riscv: Optimize strlen()Eric Salem2-12/+57
The RISC-V Zbb extension provides instructions optimized for bit operations. Use them when available for the RISC-V port. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Eric Salem <ericsalem@gmail.com>
10 daysnewlib: riscv: Add XLEN typedef and clean up typesEric Salem4-44/+45
The size of the long data type isn't precisely defined in the C standard, so create a new typedef that uses either uint32_t or uint64_t based on XLEN. The fixed width types are more robust against any ABI changes and fit the data types of the intrinsic functions. Use the new uintxlen_t type instead of long and uintptr_t. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Eric Salem <ericsalem@gmail.com>
14 daysCygwin: console: tty::restore really restores the previous modeTakashi Yano3-26/+32
Previously, tty::restore sets the console mode to a predetermined console mode that is widely common for many non-cygwin console apps. So, if a non-cygwin app that is started from cygwin process changes the console mode and executes cygwin sub-process, the console mode is changed to the predetermined mode rather than being restored the original mode that is set by the non-cygwin app. With this patch, the console mode is stored when a cygwin process is started from non-cygwin app, then tty::restore restores the previous console mode that is used by the previous non-cygwin app when the cygwin app exits. Addresses: https://github.com/msys2/msys2-runtime/issues/268 Fixes: 3312f2d21f13 ("Cygwin: console: Redesign mode set strategy on close().") Reported-by: Eu Pin Tien, Jeremy Drake <cygwin@jdrake.com> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2025-03-20Cygwin: doc: improve Solaris ACL documentationCorinna Vinschen1-10/+21
Document including cygwin/acl.h functions when using Solaris ACL functions. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-03-18Cygwin: bump DLL version to 3.7.0cygwin-3.7.0-devCorinna Vinschen1-1/+1
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-03-18Cygwin: doc: rename sched_setpolicy(2) to sched_setscheduler(2)cygwin-3.6.0Christian Franke1-2/+2
The function sched_setpolicy(2) does not exist. Fixes: 757424f74400 ("Cygwin: doc: document sched_setpolicy(2) and priority mapping") Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-03-18Cygwin: doc: clarify release message in terms of old NT4/Samba sharesCorinna Vinschen2-2/+2
Fixes: b9ed33dec0cb ("Cygwin: readdir: drop support for NT4/Win2K shares and Samba < 3.0.22") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-03-18Cygwin: Carry process affinity through to resultMark Geisert2-2/+13
Due to deficient testing, the current code doesn't return a valid result to users of sched_getaffinity(). The updated code carries the determined procmask through to the generation of result cpu mask. Recognize Windows' limitation that if the process is multi-group (i.e., has threads in multiple cpu groups) there is no visibility to which processors in other groups are being used. One could remedy this by looping through all the process' threads, but that could be expensive so is left for future contemplation. In addition, we'd have to maintain our own copy of each thread's current group and mask in internal overhead. (By the way, multi-group processes are only possible on Windows systems with more than 64 hardware threads.) Reported-by: Christian Franke <Christian.Franke@t-online.de> Addresses: https://cygwin.com/pipermail/cygwin/2025-March/257616.html Signed-off-by: Mark Geisert <mark@maxrnd.com> Fixes: 641ecb07533e ("Cygwin: Implement sched_[gs]etaffinity()")
2025-03-17fix native symlink spawn passing wrong arg0Chris Denton1-1/+3
Currently when starting a process from bash via a native symlink, argv[0] is set to the realpath of the executable and not to the link name. This patch fixes it so the path of the symlink is seen instead. The cause is a path conversion in perhaps_suffix which follows native symlinks. Hence the fix this patch uses is to add PC_SYM_NOFOLLOW_REP when calling path_conv::check to prevent that. Fixes: be371651146c ("* path.cc (path_conv::check): Don't follow reparse point symlinks if PC_SYM_NOFOLLOW_REP flag is set.") Signed-off-by: Chris Denton <chris@chrisdenton.dev>
2025-03-14Cygwin: don't export arc4random_addrandom/arc4random_stirCorinna Vinschen2-5/+2
Keep the functions for backward compatibility, but don't export them from libcygwin.a for new applications. Drop the workaround from commit ad29c33229e5 ("Cygwin: stdlib.h: revert declaring arc4random_stir() as function"). Fixes: ad29c33229e5 ("Cygwin: stdlib.h: revert declaring arc4random_stir() as function") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-03-14newlib: fix uninitialized character count being used when printing float ↵Igor Petrov2-0/+2
without "_printf_float" being linked Patch fixes wrong number of written characters being returend from 'printf' family of functionsx when '_printf_float' is not linked (nano.specs). If user tries to print a floating point number anyway, returned number of written characters is not correct. For example in printf("%d%f", 1, 1.0); should return 1, but actaully returns 2.
2025-03-15Cygwin: signal: Remove context_copy in call_signal_handler()Takashi Yano1-2/+1
After the commit 1d97f8aa4385, context_copy in call_signal_handle() is not used anymore. This patch removes it. Fixes: 1d97f8aa4385 ("Cygwin: signals: don't evaluate SA_SIGINFO context after handler returns") Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2025-03-15Cygwin: signal: Use context locally copied in call_signal_handler()Takashi Yano1-19/+22
If the signal handler is called from inside of another signal handler, _cygtls::context may be destroyed by call_signal_handler() newly called. To avoid this situation, this patch used context locally copied in call_signal_handler(). Addresses: https://cygwin.com/pipermail/cygwin-patches/2025q1/013483.html Fixes: 9043956ce859 ("Only construct ucontext for SA_SIGINFO signal handlers") Reported-by: Takashi Yano <takashi.yano@nifty.ne.jp> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
generated by cgit v1.1 at 2025-04-03 22:14:35 +0000