aboutsummaryrefslogtreecommitdiff
path: root/winsup
diff options
context:
space:
mode:
authorKen Brown <kbrown@cornell.edu>2022-05-22 11:43:44 -0400
committerKen Brown <kbrown@cornell.edu>2022-05-25 12:22:47 -0400
commit807318b6eeb127b8e62d9a170aa61639bb8571b4 (patch)
tree947bdc3d63daaf543d8dc1611cada9d3d05225d2 /winsup
parenta8629d6eaf4695d353b73f9d88aa123fedc2827a (diff)
downloadnewlib-807318b6eeb127b8e62d9a170aa61639bb8571b4.zip
newlib-807318b6eeb127b8e62d9a170aa61639bb8571b4.tar.gz
newlib-807318b6eeb127b8e62d9a170aa61639bb8571b4.tar.bz2
Cygwin: fix mknod (64-bit only)
The current definition of mknod in syscalls.cc has a third argument of type __dev16_t instead of dev_t. Fix this on 64-bit Cygwin by making the existing mknod 32-bit only and then exporting mknod as an alias for mknod32. (No fix is needed on 32-bit because mknod is redirected to mknod32 via NEW_FUNCTIONS in Makefile.am.) Addresses: https://cygwin.com/pipermail/cygwin-developers/2022-May/012589.html
Diffstat (limited to 'winsup')
-rw-r--r--winsup/cygwin/release/3.3.63
-rw-r--r--winsup/cygwin/syscalls.cc4
2 files changed, 7 insertions, 0 deletions
diff --git a/winsup/cygwin/release/3.3.6 b/winsup/cygwin/release/3.3.6
index 6d72243..135f331 100644
--- a/winsup/cygwin/release/3.3.6
+++ b/winsup/cygwin/release/3.3.6
@@ -7,3 +7,6 @@ Bug Fixes
- Fix killpg failing because the exec'ing as well as the exec'ed
process are not in the pidlist for a brief moment.
Addresses: https://cygwin.com/pipermail/cygwin/2022-May/251479.html
+
+- Fix mknod (64-bit only), whose definition didn't match its prototype.
+ Addresses: https://cygwin.com/pipermail/cygwin-developers/2022-May/012589.html
diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index d431442..03fed03 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -3488,11 +3488,15 @@ mknod32 (const char *path, mode_t mode, dev_t dev)
return -1;
}
+#ifdef __i386__
extern "C" int
mknod (const char *_path, mode_t mode, __dev16_t dev)
{
return mknod32 (_path, mode, (dev_t) dev);
}
+#else
+EXPORT_ALIAS (mknod32, mknod)
+#endif
extern "C" int
mkfifo (const char *path, mode_t mode)