diff options
author | Sandra Loosemore <sandra@codesourcery.com> | 2020-02-04 21:34:13 -0700 |
---|---|---|
committer | Corinna Vinschen <corinna@vinschen.de> | 2020-02-06 11:02:38 +0100 |
commit | cd78225a50205aa07d726b7310b333e9c07471bc (patch) | |
tree | 69d3df41ad7a1c82269fe5eaa8e0c8e825cb0195 /libgloss | |
parent | 65ad1c0ab0a434fb52d23b96fb072634ac263471 (diff) | |
download | newlib-cd78225a50205aa07d726b7310b333e9c07471bc.zip newlib-cd78225a50205aa07d726b7310b333e9c07471bc.tar.gz newlib-cd78225a50205aa07d726b7310b333e9c07471bc.tar.bz2 |
libgloss: Fix lseek semihosting bug on nios2 and m68k
When off_t is 32 bits, the value needs to be sign-extended to 64 bits
before shifting right to extract the high-order word. Previously
negative offsets were incorrectly encoded.
Signed-off-by: Sandra Loosemore <sandra@codesourcery.com>
Diffstat (limited to 'libgloss')
-rw-r--r-- | libgloss/m68k/io-lseek.c | 2 | ||||
-rw-r--r-- | libgloss/nios2/io-lseek.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/libgloss/m68k/io-lseek.c b/libgloss/m68k/io-lseek.c index 63ec564..eaaf557 100644 --- a/libgloss/m68k/io-lseek.c +++ b/libgloss/m68k/io-lseek.c @@ -38,7 +38,7 @@ off_t lseek (int fd, off_t offset, int whence) #if HOSTED gdb_parambuf_t parameters; parameters[0] = (uint32_t) fd; - parameters[1] = (uint32_t) ((offset >> 32) & 0xffffffff); + parameters[1] = (uint32_t) ((int64_t)offset >> 32); parameters[2] = (uint32_t) (offset & 0xffffffff); parameters[3] = __hosted_to_gdb_lseek_flags (whence); __hosted (HOSTED_LSEEK, parameters); diff --git a/libgloss/nios2/io-lseek.c b/libgloss/nios2/io-lseek.c index bfc23c1..d47fe07 100644 --- a/libgloss/nios2/io-lseek.c +++ b/libgloss/nios2/io-lseek.c @@ -39,7 +39,7 @@ off_t lseek (int fd, off_t offset, int whence) #if HOSTED gdb_parambuf_t parameters; parameters[0] = (uint32_t) fd; - parameters[1] = (uint32_t) ((offset >> 32) & 0xffffffff); + parameters[1] = (uint32_t) ((int64_t)offset >> 32); parameters[2] = (uint32_t) (offset & 0xffffffff); parameters[3] = __hosted_to_gdb_lseek_flags (whence); __io_hosted (HOSTED_LSEEK, parameters); |