diff options
| author | Takashi Yano <takashi.yano@nifty.ne.jp> | 2022-03-30 12:46:08 +0900 |
|---|---|---|
| committer | Takashi Yano <takashi.yano@nifty.ne.jp> | 2022-03-30 12:55:38 +0900 |
| commit | c7300b91d026eb031ffe2864ab27fd859626bc8c (patch) | |
| tree | 4f68708fa8ad54d66b4035aaed7a133995e423e3 | |
| parent | 8a12474bb5d287d73229270509b49a0c6b8fcabb (diff) | |
| download | newlib-c7300b91d026eb031ffe2864ab27fd859626bc8c.zip newlib-c7300b91d026eb031ffe2864ab27fd859626bc8c.tar.gz newlib-c7300b91d026eb031ffe2864ab27fd859626bc8c.tar.bz2 | |
Cygwin: pty: Fix crash on master close in Windows 7.
- The 4th parameter of WriteFile() cannot be NULL especially in
Windows 7 as mentioned in Microsoft documentation. This patch
fixes that.
Addresses: https://cygwin.com/pipermail/cygwin/2022-March/251162.html
| -rw-r--r-- | winsup/cygwin/fhandler_tty.cc | 2 | ||||
| -rw-r--r-- | winsup/cygwin/release/3.3.5 | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc index f78dc76..3675250 100644 --- a/winsup/cygwin/fhandler_tty.cc +++ b/winsup/cygwin/fhandler_tty.cc @@ -2172,7 +2172,7 @@ fhandler_pty_master::close () } release_output_mutex (); get_ttyp ()->stop_fwd_thread = true; - WriteFile (to_master_nat, "", 0, NULL, NULL); + WriteFile (to_master_nat, "", 0, &len, NULL); master_fwd_thread->detach (); } } diff --git a/winsup/cygwin/release/3.3.5 b/winsup/cygwin/release/3.3.5 index d2a7f77..9d44c1b 100644 --- a/winsup/cygwin/release/3.3.5 +++ b/winsup/cygwin/release/3.3.5 @@ -43,3 +43,6 @@ Bug Fixes - Fix a formatting problem in gmondump where all displayed addresses are mistakenly prefixed with "0x0x". + +- Fix crash on pty master close in Windows 7. + Addresses: https://cygwin.com/pipermail/cygwin/2022-March/251162.html |