From 58953b8ef56a41feeaf976e22aeda3ee5acce481 Mon Sep 17 00:00:00 2001 From: Christian Ulmann Date: Mon, 25 Aug 2025 13:46:13 +0200 Subject: Revert "[MLIR] Fix duplicated attribute nodes in MLIR bytecode deserialization (#151267) (#155214) This reverts commit c075fb8c37856365fb76d986ad3aefa2400b3240. This commit introduces a caching bug that causes undesired collisions. --- mlir/lib/Bytecode/Reader/BytecodeReader.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'mlir/lib/Bytecode/Reader/BytecodeReader.cpp') diff --git a/mlir/lib/Bytecode/Reader/BytecodeReader.cpp b/mlir/lib/Bytecode/Reader/BytecodeReader.cpp index 0f97443..44458d0 100644 --- a/mlir/lib/Bytecode/Reader/BytecodeReader.cpp +++ b/mlir/lib/Bytecode/Reader/BytecodeReader.cpp @@ -895,10 +895,6 @@ private: SmallVector attributes; SmallVector types; - /// The map of cached attributes, used to avoid re-parsing the same - /// attribute multiple times. - llvm::StringMap attributesCache; - /// A location used for error emission. Location fileLoc; @@ -1239,7 +1235,7 @@ LogicalResult AttrTypeReader::parseAsmEntry(T &result, EncodingReader &reader, ::parseType(asmStr, context, &numRead, /*isKnownNullTerminated=*/true); else result = ::parseAttribute(asmStr, context, Type(), &numRead, - /*isKnownNullTerminated=*/true, &attributesCache); + /*isKnownNullTerminated=*/true); if (!result) return failure(); -- cgit v1.1