From 459a82e6890ff41e30d486f36c8c7ec22628bb7a Mon Sep 17 00:00:00 2001 From: JOE1994 Date: Fri, 13 Sep 2024 19:34:30 -0400 Subject: [llvm][unittests] Don't call raw_string_ostream::flush() (NFC) raw_string_ostream::flush() is essentially a no-op (also specified in docs). Don't call it in tests that aren't meant to test 'raw_string_ostream' itself. p.s. remove a few redundant calls to raw_string_ostream::str() --- llvm/unittests/Support/VirtualFileSystemTest.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'llvm/unittests/Support/VirtualFileSystemTest.cpp') diff --git a/llvm/unittests/Support/VirtualFileSystemTest.cpp b/llvm/unittests/Support/VirtualFileSystemTest.cpp index 8d1eb69..eb590e4 100644 --- a/llvm/unittests/Support/VirtualFileSystemTest.cpp +++ b/llvm/unittests/Support/VirtualFileSystemTest.cpp @@ -2927,7 +2927,6 @@ TEST_F(VFSFromYAMLTest, YAMLVFSWriterTest) { std::string Buffer; raw_string_ostream OS(Buffer); VFSWriter.write(OS); - OS.flush(); IntrusiveRefCntPtr Lower(new ErrorDummyFileSystem()); Lower->addDirectory("//root/"); @@ -2978,7 +2977,6 @@ TEST_F(VFSFromYAMLTest, YAMLVFSWriterTest2) { std::string Buffer; raw_string_ostream OS(Buffer); VFSWriter.write(OS); - OS.flush(); IntrusiveRefCntPtr Lower(new ErrorDummyFileSystem()); IntrusiveRefCntPtr FS = getFromYAMLRawString(Buffer, Lower); @@ -3011,7 +3009,6 @@ TEST_F(VFSFromYAMLTest, YAMLVFSWriterTest3) { std::string Buffer; raw_string_ostream OS(Buffer); VFSWriter.write(OS); - OS.flush(); IntrusiveRefCntPtr Lower(new ErrorDummyFileSystem()); IntrusiveRefCntPtr FS = getFromYAMLRawString(Buffer, Lower); @@ -3032,7 +3029,6 @@ TEST_F(VFSFromYAMLTest, YAMLVFSWriterTestHandleDirs) { std::string Buffer; raw_string_ostream OS(Buffer); VFSWriter.write(OS); - OS.flush(); // We didn't add a single file - only directories. EXPECT_EQ(Buffer.find("'type': 'file'"), std::string::npos); -- cgit v1.1