From 8ef8b7373e822d66336d50c7a0a6078aa59e8acd Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Sun, 8 Jun 2014 17:33:47 +0000 Subject: SmallVectorTest: Remove some more robust checks added in r210429 since they caught some bugs I haven't fixed yet. Specifically this caused inserting an element from a SmallVector into itself when such an insertion would cause a reallocation. We have code to handle this for non-reallocating cases, but it's not robust against reallocation. llvm-svn: 210430 --- llvm/unittests/ADT/SmallVectorTest.cpp | 6 ------ 1 file changed, 6 deletions(-) (limited to 'llvm/unittests/ADT/SmallVectorTest.cpp') diff --git a/llvm/unittests/ADT/SmallVectorTest.cpp b/llvm/unittests/ADT/SmallVectorTest.cpp index 935c761..cceed7b 100644 --- a/llvm/unittests/ADT/SmallVectorTest.cpp +++ b/llvm/unittests/ADT/SmallVectorTest.cpp @@ -42,15 +42,12 @@ public: } Constructable(const Constructable & src) : constructed(true) { - EXPECT_TRUE(src.constructed); value = src.value; ++numConstructorCalls; } Constructable(Constructable && src) : constructed(true) { - EXPECT_TRUE(src.constructed); value = src.value; - src.value = -1; ++numConstructorCalls; } @@ -62,7 +59,6 @@ public: Constructable & operator=(const Constructable & src) { EXPECT_TRUE(constructed); - EXPECT_TRUE(src.constructed); value = src.value; ++numAssignmentCalls; return *this; @@ -70,9 +66,7 @@ public: Constructable & operator=(Constructable && src) { EXPECT_TRUE(constructed); - EXPECT_TRUE(src.constructed); value = src.value; - src.value = -1; ++numAssignmentCalls; return *this; } -- cgit v1.1