From b4482f7ca04e852cf610ef0e16542c888844d93d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 2 Dec 2022 21:11:40 -0800 Subject: [tools] Use std::nullopt instead of None (NFC) This patch mechanically replaces None with std::nullopt where the compiler would warn if None were deprecated. The intent is to reduce the amount of manual work required in migrating from Optional to std::optional. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 --- llvm/tools/llvm-objdump/llvm-objdump.cpp | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp') diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 0757e3b..7b95642 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -869,7 +869,7 @@ static Optional getWasmCodeSection(const WasmObjectFile &Obj) { if (Section.Type == wasm::WASM_SEC_CODE) return SecI; } - return None; + return std::nullopt; } static void @@ -1101,7 +1101,7 @@ static SymbolInfoTy createDummySymbolInfo(const ObjectFile &Obj, const uint64_t Addr, StringRef &Name, uint8_t Type) { if (Obj.isXCOFF() && SymbolDescription) - return SymbolInfoTy(Addr, Name, None, None, false); + return SymbolInfoTy(Addr, Name, std::nullopt, std::nullopt, false); else return SymbolInfoTy(Addr, Name, Type); } @@ -1276,14 +1276,14 @@ static Optional> fetchBinaryByBuildID(const ObjectFile &Obj) { Optional BuildID = getBuildID(&Obj); if (!BuildID) - return None; + return std::nullopt; Optional Path = BIDFetcher->fetch(*BuildID); if (!Path) - return None; + return std::nullopt; Expected> DebugBinary = createBinary(*Path); if (!DebugBinary) { reportWarning(toString(DebugBinary.takeError()), *Path); - return None; + return std::nullopt; } return std::move(*DebugBinary); } @@ -1423,13 +1423,12 @@ static void disassembleObject(const Target *TheTarget, ObjectFile &Obj, LLVM_DEBUG(LVP.dump()); std::unordered_map AddrToBBAddrMap; - auto ReadBBAddrMap = [&](Optional SectionIndex = None) { + auto ReadBBAddrMap = [&](Optional SectionIndex = std::nullopt) { AddrToBBAddrMap.clear(); if (const auto *Elf = dyn_cast(&Obj)) { auto BBAddrMapsOrErr = Elf->readBBAddrMap(SectionIndex); if (!BBAddrMapsOrErr) - reportWarning(toString(BBAddrMapsOrErr.takeError()), - Obj.getFileName()); + reportWarning(toString(BBAddrMapsOrErr.takeError()), Obj.getFileName()); for (auto &FunctionBBAddrMap : *BBAddrMapsOrErr) AddrToBBAddrMap.emplace(FunctionBBAddrMap.Addr, std::move(FunctionBBAddrMap)); -- cgit v1.1