From a78027630133ac39a8edf09a91ca203a6a980dbe Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 5 Jul 2019 12:31:32 +0000 Subject: lld, llvm-dlltool, llvm-lib: Use getAsString() instead of getSpelling() for printing unknown args Since OPT_UNKNOWN args never have any values and consist only of spelling (and are never aliased), this doesn't make any difference in practice, but it's more consistent with Arg's guidance to use getAsString() for diagnostics, and it matches what clang does. Also tweak two tests to use an unknown option that contains '=' for additional coverage while here. (The new tests pass fine with the old code too though.) llvm-svn: 365200 --- llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp') diff --git a/llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp b/llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp index 1201b28..18ab663 100644 --- a/llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp +++ b/llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp @@ -163,7 +163,8 @@ int llvm::libDriverMain(ArrayRef ArgsArr) { return 1; } for (auto *Arg : Args.filtered(OPT_UNKNOWN)) - llvm::errs() << "ignoring unknown argument: " << Arg->getSpelling() << "\n"; + llvm::errs() << "ignoring unknown argument: " << Arg->getAsString(Args) + << "\n"; // Handle /help if (Args.hasArg(OPT_help)) { -- cgit v1.1