From a30139d50cb954ea6c2a7d0c2540ddb4b3d70d97 Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Wed, 29 Jun 2016 05:33:24 +0000 Subject: Revert "[Coverage] Clarify ownership of a MemoryBuffer in the reader (NFC)" This reverts commit 1037ef2574adde2103ad221d63834c3e1df4a776. llvm-svn: 274105 --- llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp') diff --git a/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp b/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp index 1230054..1a4b4f5 100644 --- a/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp @@ -641,7 +641,8 @@ static Error loadBinaryFormat(MemoryBufferRef ObjectBuffer, } Expected> -BinaryCoverageReader::create(MemoryBuffer &ObjectBuffer, StringRef Arch) { +BinaryCoverageReader::create(std::unique_ptr &ObjectBuffer, + StringRef Arch) { std::unique_ptr Reader(new BinaryCoverageReader()); StringRef Coverage; @@ -649,12 +650,12 @@ BinaryCoverageReader::create(MemoryBuffer &ObjectBuffer, StringRef Arch) { support::endianness Endian; Error E; consumeError(std::move(E)); - if (ObjectBuffer.getBuffer().startswith(TestingFormatMagic)) + if (ObjectBuffer->getBuffer().startswith(TestingFormatMagic)) // This is a special format used for testing. - E = loadTestingFormat(ObjectBuffer.getBuffer(), Reader->ProfileNames, + E = loadTestingFormat(ObjectBuffer->getBuffer(), Reader->ProfileNames, Coverage, BytesInAddress, Endian); else - E = loadBinaryFormat(ObjectBuffer.getMemBufferRef(), Reader->ProfileNames, + E = loadBinaryFormat(ObjectBuffer->getMemBufferRef(), Reader->ProfileNames, Coverage, BytesInAddress, Endian, Arch); if (E) return std::move(E); -- cgit v1.1