From 7a7f5348a78f11ccc91c41e637847a4994b09fbf Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Tue, 21 Jun 2016 22:22:33 +0000 Subject: [Coverage] Clarify ownership of a MemoryBuffer in the reader (NFC) Pass a `MemoryBuffer &` to BinaryCoverageReader::create() instead of a `std::unique_ptr &`. This makes it easier to reason about the ownership of the buffer at a glance. llvm-svn: 273326 --- llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp') diff --git a/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp b/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp index 1a4b4f5..1230054 100644 --- a/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp @@ -641,8 +641,7 @@ static Error loadBinaryFormat(MemoryBufferRef ObjectBuffer, } Expected> -BinaryCoverageReader::create(std::unique_ptr &ObjectBuffer, - StringRef Arch) { +BinaryCoverageReader::create(MemoryBuffer &ObjectBuffer, StringRef Arch) { std::unique_ptr Reader(new BinaryCoverageReader()); StringRef Coverage; @@ -650,12 +649,12 @@ BinaryCoverageReader::create(std::unique_ptr &ObjectBuffer, support::endianness Endian; Error E; consumeError(std::move(E)); - if (ObjectBuffer->getBuffer().startswith(TestingFormatMagic)) + if (ObjectBuffer.getBuffer().startswith(TestingFormatMagic)) // This is a special format used for testing. - E = loadTestingFormat(ObjectBuffer->getBuffer(), Reader->ProfileNames, + E = loadTestingFormat(ObjectBuffer.getBuffer(), Reader->ProfileNames, Coverage, BytesInAddress, Endian); else - E = loadBinaryFormat(ObjectBuffer->getMemBufferRef(), Reader->ProfileNames, + E = loadBinaryFormat(ObjectBuffer.getMemBufferRef(), Reader->ProfileNames, Coverage, BytesInAddress, Endian, Arch); if (E) return std::move(E); -- cgit v1.1