From 7a7f5348a78f11ccc91c41e637847a4994b09fbf Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Tue, 21 Jun 2016 22:22:33 +0000 Subject: [Coverage] Clarify ownership of a MemoryBuffer in the reader (NFC) Pass a `MemoryBuffer &` to BinaryCoverageReader::create() instead of a `std::unique_ptr &`. This makes it easier to reason about the ownership of the buffer at a glance. llvm-svn: 273326 --- llvm/lib/ProfileData/Coverage/CoverageMapping.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'llvm/lib/ProfileData/Coverage/CoverageMapping.cpp') diff --git a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp index 2d83320..ac3fe46 100644 --- a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp @@ -236,11 +236,13 @@ CoverageMapping::load(CoverageMappingReader &CoverageReader, Expected> CoverageMapping::load(StringRef ObjectFilename, StringRef ProfileFilename, StringRef Arch) { - auto CounterMappingBuff = MemoryBuffer::getFileOrSTDIN(ObjectFilename); - if (std::error_code EC = CounterMappingBuff.getError()) + auto CounterMappingBufOrErr = MemoryBuffer::getFileOrSTDIN(ObjectFilename); + if (std::error_code EC = CounterMappingBufOrErr.getError()) return errorCodeToError(EC); + std::unique_ptr ObjectBuffer = + std::move(CounterMappingBufOrErr.get()); auto CoverageReaderOrErr = - BinaryCoverageReader::create(CounterMappingBuff.get(), Arch); + BinaryCoverageReader::create(*ObjectBuffer.get(), Arch); if (Error E = CoverageReaderOrErr.takeError()) return std::move(E); auto CoverageReader = std::move(CoverageReaderOrErr.get()); -- cgit v1.1