From ac00376a13e9b637a8bc6b9e2ae6fd668e01b0f9 Mon Sep 17 00:00:00 2001 From: vgxbj Date: Fri, 10 Apr 2020 20:24:21 +0800 Subject: [Object] Change uint32_t getSymbolFlags() to Expected getSymbolFlags(). This change enables getSymbolFlags() to return errors which benefit error reporting in clients. Differential Revision: https://reviews.llvm.org/D77860 --- llvm/lib/Object/ObjectFile.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'llvm/lib/Object/ObjectFile.cpp') diff --git a/llvm/lib/Object/ObjectFile.cpp b/llvm/lib/Object/ObjectFile.cpp index 1453f9d..fe90378 100644 --- a/llvm/lib/Object/ObjectFile.cpp +++ b/llvm/lib/Object/ObjectFile.cpp @@ -55,11 +55,14 @@ bool SectionRef::containsSymbol(SymbolRef S) const { } uint64_t ObjectFile::getSymbolValue(DataRefImpl Ref) const { - uint32_t Flags = getSymbolFlags(Ref); - if (Flags & SymbolRef::SF_Undefined) - return 0; - if (Flags & SymbolRef::SF_Common) - return getCommonSymbolSize(Ref); + if (Expected FlagsOrErr = getSymbolFlags(Ref)) { + if (*FlagsOrErr & SymbolRef::SF_Undefined) + return 0; + if (*FlagsOrErr & SymbolRef::SF_Common) + return getCommonSymbolSize(Ref); + } else + // TODO: Actually report errors helpfully. + report_fatal_error(FlagsOrErr.takeError()); return getSymbolValueImpl(Ref); } -- cgit v1.1