From b4865d698be45ae548284720da4a60fd9f0e3f44 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 3 Apr 2014 00:19:35 +0000 Subject: Revert "Fix a nomenclature error in llvm-nm." This reverts commit r205479. It turns out that nm does use addresses, it is just that every reasonable relocatable ELF object has sections with address 0. I have no idea if those exist in reality, but it at least it shows that llvm-nm should use the name address. The added test was includes an unusual .o file with non 0 section addresses. I created it by hacking ELFObjectWriter.cpp. Really sorry for the churn. llvm-svn: 205493 --- llvm/lib/Object/MachOObjectFile.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'llvm/lib/Object/MachOObjectFile.cpp') diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp index df4e044..6955ef0 100644 --- a/llvm/lib/Object/MachOObjectFile.cpp +++ b/llvm/lib/Object/MachOObjectFile.cpp @@ -633,8 +633,7 @@ MachOObjectFile::getSymbolSection(DataRefImpl Symb, error_code MachOObjectFile::getSymbolValue(DataRefImpl Symb, uint64_t &Val) const { - // In MachO both relocatable and non-relocatable objects have addresses. - return getSymbolAddress(Symb, Val); + report_fatal_error("getSymbolValue unimplemented in MachOObjectFile"); } void MachOObjectFile::moveSectionNext(DataRefImpl &Sec) const { -- cgit v1.1