From f59216b58f3379ba3885a61018cff51578a1fb21 Mon Sep 17 00:00:00 2001 From: Georgii Rymar Date: Mon, 9 Nov 2020 11:50:50 +0300 Subject: Revert "[llvm-readelf/obj] - Allow dumping of ELF header even if some elements are corrupt." This reverts commit ea8a0b8b29eb08d3f0f6ac40942a2d8e98ab57ee. It broke BBots. http://lab.llvm.org:8011/#/builders/14/builds/1439 http://lab.llvm.org:8011/#/builders/112/builds/913 --- llvm/lib/Object/ELFObjectFile.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'llvm/lib/Object/ELFObjectFile.cpp') diff --git a/llvm/lib/Object/ELFObjectFile.cpp b/llvm/lib/Object/ELFObjectFile.cpp index c654c3f..6dee3ab 100644 --- a/llvm/lib/Object/ELFObjectFile.cpp +++ b/llvm/lib/Object/ELFObjectFile.cpp @@ -61,15 +61,15 @@ ELFObjectFileBase::ELFObjectFileBase(unsigned int Type, MemoryBufferRef Source) template static Expected>> -createPtr(MemoryBufferRef Object, bool InitContent) { - auto Ret = ELFObjectFile::create(Object, InitContent); +createPtr(MemoryBufferRef Object) { + auto Ret = ELFObjectFile::create(Object); if (Error E = Ret.takeError()) return std::move(E); return std::make_unique>(std::move(*Ret)); } Expected> -ObjectFile::createELFObjectFile(MemoryBufferRef Obj, bool InitContent) { +ObjectFile::createELFObjectFile(MemoryBufferRef Obj) { std::pair Ident = getElfArchType(Obj.getBuffer()); std::size_t MaxAlignment = @@ -80,16 +80,16 @@ ObjectFile::createELFObjectFile(MemoryBufferRef Obj, bool InitContent) { if (Ident.first == ELF::ELFCLASS32) { if (Ident.second == ELF::ELFDATA2LSB) - return createPtr(Obj, InitContent); + return createPtr(Obj); else if (Ident.second == ELF::ELFDATA2MSB) - return createPtr(Obj, InitContent); + return createPtr(Obj); else return createError("Invalid ELF data"); } else if (Ident.first == ELF::ELFCLASS64) { if (Ident.second == ELF::ELFDATA2LSB) - return createPtr(Obj, InitContent); + return createPtr(Obj); else if (Ident.second == ELF::ELFDATA2MSB) - return createPtr(Obj, InitContent); + return createPtr(Obj); else return createError("Invalid ELF data"); } -- cgit v1.1