From 4ffe3ac729aa7a9863ea9a7bd451785a787d7ad8 Mon Sep 17 00:00:00 2001 From: Juneyoung Lee Date: Mon, 16 Mar 2020 12:45:54 +0900 Subject: Revert "[CodeGenPrepare] Freeze condition when transforming select to br" This reverts commit 10aa7ea951e22dbd7f2ebdeb6410cfbc8a251eb1. --- llvm/lib/CodeGen/CodeGenPrepare.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'llvm/lib/CodeGen/CodeGenPrepare.cpp') diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp index fd55ef2..373064d 100644 --- a/llvm/lib/CodeGen/CodeGenPrepare.cpp +++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp @@ -6131,8 +6131,7 @@ bool CodeGenPrepare::optimizeSelectInst(SelectInst *SI) { // Into: // start: // %cmp = cmp uge i32 %a, %b - // %cmp.frozen = freeze %cmp - // br i1 %cmp.frozen, label %select.true, label %select.false + // br i1 %cmp, label %select.true, label %select.false // select.true: // br label %select.end // select.false: @@ -6140,7 +6139,6 @@ bool CodeGenPrepare::optimizeSelectInst(SelectInst *SI) { // select.end: // %sel = phi i32 [ %c, %select.true ], [ %d, %select.false ] // - // %cmp should be freezed, otherwise it may introduce undefined behavior. // In addition, we may sink instructions that produce %c or %d from // the entry block into the destination(s) of the new branch. // If the true or false blocks do not contain a sunken instruction, that @@ -6219,9 +6217,7 @@ bool CodeGenPrepare::optimizeSelectInst(SelectInst *SI) { TT = TrueBlock; FT = FalseBlock; } - IRBuilder<> IB(SI); - auto CondFr = IB.CreateFreeze(SI->getCondition(), SI->getName() + ".frozen"); - IB.CreateCondBr(CondFr, TT, FT, SI); + IRBuilder<>(SI).CreateCondBr(SI->getCondition(), TT, FT, SI); SmallPtrSet INS; INS.insert(ASI.begin(), ASI.end()); -- cgit v1.1