From ed2c3218f5badf88cb7897fabf8faa01e8aa2044 Mon Sep 17 00:00:00 2001 From: Mitch Phillips <31459023+hctim@users.noreply.github.com> Date: Mon, 16 May 2022 19:07:22 -0700 Subject: Revert "[dwarf] Emit a DIGlobalVariable for constant strings." This reverts commit 4680982b36a84770a1600fc438be8ec090671724. Broke a fuchsia windows bot. More details in the review: https://reviews.llvm.org/D123534 --- llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp') diff --git a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp index ece4167..83d77cb 100644 --- a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp @@ -3175,11 +3175,6 @@ void CodeViewDebug::collectGlobalVariableInfo() { for (const auto *GVE : CU->getGlobalVariables()) { const DIGlobalVariable *DIGV = GVE->getVariable(); const DIExpression *DIE = GVE->getExpression(); - // Don't emit string literals in CodeView, as the only useful parts are - // generally the filename and line number, which isn't possible to output - // in CodeView. String literals should be the only unnamed GlobalVariable - // with debug info. - if (DIGV->getName().empty()) continue; if ((DIE->getNumElements() == 2) && (DIE->getElement(0) == dwarf::DW_OP_plus_uconst)) -- cgit v1.1