From 3b9994615f484d028ab476cf31bf6e62558364e8 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 11 Jul 2019 10:53:40 +0000 Subject: Revert [BitcodeReader] Validate OpNum, before accessing Record array. This reverts r365750 (git commit 8b222ecf2769ee133691f208f6166ce118c4a164) llvm-dis runs out of memory while opening invalid-fcmp-opnum.bc on llvm-hexagon-elf, probably because the bitcode file contains other suspicious values. http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/21949 llvm-svn: 365757 --- llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp') diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index 0d302b7..0ba76f0 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -4165,10 +4165,6 @@ Error BitcodeReader::parseFunctionBody(Function *F) { popValue(Record, OpNum, NextValueNo, LHS->getType(), RHS)) return error("Invalid record"); - if (OpNum >= Record.size()) - return error( - "Invalid record: operand number exceeded available operands"); - unsigned PredVal = Record[OpNum]; bool IsFP = LHS->getType()->isFPOrFPVectorTy(); FastMathFlags FMF; -- cgit v1.1