From 722339dc0927545834afffd8aca9a75efd450ca9 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 3 Sep 2025 10:51:09 -0700 Subject: [lldb] Revert custom __str__ in SBStructuredDataExtensions.i (#156721) `__str__` was implemented in #155061, however its behavior was limited to only a some kinds of `SBStructuredData`. That was a breaking change, and this change removes that implementation of `__str__`, relying on the existing behavior which calls `GetDescription`. --- .../API/python_api/sbstructureddata/TestStructuredDataAPI.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'lldb/test/API/python_api') diff --git a/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py b/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py index 6c0058863651..275ac03a5a86 100644 --- a/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py +++ b/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py @@ -48,6 +48,8 @@ class TestStructuredDataAPI(TestBase): s.Clear() error = example.GetDescription(s) self.assertSuccess(error, "GetDescription works") + # Ensure str() doesn't raise an exception. + self.assertTrue(str(example)) if not "key_float" in s.GetData(): self.fail("FAILED: could not find key_float in description output") @@ -344,7 +346,7 @@ class TestStructuredDataAPI(TestBase): self.fail("wrong output: " + str(output)) def test_round_trip_scalars(self): - for original in (0, 11, -1, 0.0, 4.5, -0.25, "", "dirk", True, False): + for original in (0, 11, -1, 0.0, 4.5, -0.25, True, False): constructor = type(original) data = lldb.SBStructuredData() data.SetFromJSON(json.dumps(original)) @@ -357,13 +359,6 @@ class TestStructuredDataAPI(TestBase): data.SetFromJSON(json.dumps(original)) self.assertEqual(data.dynamic, original) - def test_round_trip_string(self): - # No 0.0, it inherently does not round trip. - for original in (0, 11, -1, 4.5, -0.25, "", "dirk"): - data = lldb.SBStructuredData() - data.SetFromJSON(json.dumps(original)) - self.assertEqual(str(data), str(original)) - def test_round_trip_int(self): for original in (0, 11, -1): data = lldb.SBStructuredData() -- cgit v1.2.3